Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guess, no tags for migrations and config #49

Open
erimeilis opened this issue Dec 25, 2024 · 5 comments
Open

Guess, no tags for migrations and config #49

erimeilis opened this issue Dec 25, 2024 · 5 comments

Comments

@erimeilis
Copy link

Get
No publishable resources for tag [laravel-lockable-migrations].
No publishable resources for tag [laravel-lockable-config].

@lrljoe
Copy link
Member

lrljoe commented Dec 26, 2024

Thanks for the heads up, I do have some bits to add in when I do the next release.

Anything feature-wise that you're wanting?

@erimeilis
Copy link
Author

Yes, i had 2 moments, that pushed me to fork..

  1. Need to add DB for locks into the config. Because i have several db's for my models, but lock tables are in the one. When i use trait for model from "old_db", it tries to find locks in it, but they are in "common_db".
    So i added
    // Name of db connection for locks table
    'locks_connection' => 'mysql',
  2. U use uuid and uuidMorphs for user_id, but, for example, i have simple bigInt id. So had to change migration slightly, - maybe that's a point for readme notice.
  3. isLocked(), as i think, won't try to acqire, cos what else shall i use for the view? just to show, what's locked and what's need a button to "take" it in job, for example

@lrljoe
Copy link
Member

lrljoe commented Dec 27, 2024

Next version addresses a couple of these,

Custom db connection for table
Updated migrations and model behaviours to allow for either uuid or bigInt pks
Optional morphable for user

Some logic to allow checking if something is locked, without locking it. It's a use case I personally don't use (which is why it's not present), but get why it's useful.

Plus I will finally get around to properly documenting properly

More than happy for PRs btw

@lrljoe
Copy link
Member

lrljoe commented Dec 27, 2024

The other key addition in the next release is per-model customisations for over-riding the default behaviours.

Apologies that I've not been updating rhe package, there's a chunk of updates in my local environments to bring in

@erimeilis
Copy link
Author

Sounds great! I'm using it to add a feature i wasn't asked to do. For the moment made quick fixes just in place, - if it be apporved for further development, surely, take part.
I'm constructing a large new dashboard for a very old business on php5.3 still, that's why services are on different db's, no chance to rebuild it all, no downtime allowed, so build it step by step on Lara ))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants