Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EepromMcuWriteBuffer hides write errors reported by the EEPROM emulation code #1620

Open
nfroggy opened this issue Oct 7, 2024 · 0 comments

Comments

@nfroggy
Copy link

nfroggy commented Oct 7, 2024

This happens at least on the Nucleo476 example code. The problem is that whoever implemented the error handling seemingly didn't understand how the EE_STATUSMASK bitmasks should be used. This line should be if( eeStatus & EE_STATUSMASK_CLEANUP ), and this line should be if( eeStatus & EE_STATUSMASK_ERROR ). The EE_STATUSMASK_CLEANUP line happens to work because there's only one bit set in that mask. The EE_STATUSMASK_ERROR mask doesn't work at all because it's 0xff, so it would require eeStatus to be 0xff which never happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant