Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature Proposal: Logout Page #29

Closed
V41SH opened this issue Jun 14, 2020 · 8 comments
Closed

New Feature Proposal: Logout Page #29

V41SH opened this issue Jun 14, 2020 · 8 comments
Labels
accepted frontend work related to frontend module:user related to users module

Comments

@V41SH
Copy link

V41SH commented Jun 14, 2020

Child of #18.

Used bootstrap modals to create a popup whenever the logout button is clicked.
This can be integrated into the user account page.

Code: https://github.com/V41SH/repo/blob/master/logout.html
Implementation: https://codepen.io/V41SH/pen/JjGKaYX

@lockedup-bot
Copy link

lockedup-bot bot commented Jun 14, 2020

Thanks @V41SH, for raising the issue! 🙌
One of our team mates will revert on this soon. ✅

@YashKumarVerma YashKumarVerma added accepted frontend work related to frontend module:user related to users module proposal proposal for task and removed accepted labels Jun 14, 2020
@YashKumarVerma
Copy link
Member

YashKumarVerma commented Jun 14, 2020

You need to create a page which says, you have been logged out.

Updated instructions posted here: #18

@V41SH
Copy link
Author

V41SH commented Jun 15, 2020

Child of #18.
Created a page that shows "You have been logged out."

Code: https://github.com/V41SH/repo/blob/master/logout2.html
Implementation: https://codepen.io/V41SH/pen/xxZExXN

@YashKumarVerma
Copy link
Member

Child of #18.
Created a page that shows "You have been logged out."

Code: https://github.com/V41SH/repo/blob/master/logout2.html
Implementation: https://codepen.io/V41SH/pen/xxZExXN

Try something like

<div class="page-wrap d-flex flex-row align-items-center">
    <div class="container">
        <div class="row justify-content-center">
            <div class="col-md-12 text-center">
                <span class="display-1 d-block">404 !</span>
                <div class="mb-4 lead">Seems like you are lost. There's nothing in here.</div>
                <a href="/" class="btn btn-primary">Let's go back home</a>
            </div>
        </div>
    </div>
</div>

@V41SH
Copy link
Author

V41SH commented Jun 16, 2020

Child of #18.
Created a page that shows "You have been logged out."

Code: https://github.com/V41SH/repo/blob/master/logout2.html
Implementation: https://codepen.io/V41SH/pen/xxZExXN

@YashKumarVerma
Copy link
Member

  • Set a proper dp.
  • why bootstrap 3.5.1 ?

@V41SH
Copy link
Author

V41SH commented Jun 17, 2020

Updated to Bootstrap 4.5.0, can be checked with the previous links itself.

@YashKumarVerma
Copy link
Member

Good. Send a pr .

@YashKumarVerma YashKumarVerma added accepted and removed proposal proposal for task labels Jun 17, 2020
@V41SH V41SH closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted frontend work related to frontend module:user related to users module
Projects
None yet
Development

No branches or pull requests

2 participants