-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS - Compilation fails when using MacPorts for v0.23.1 on Mac M1 Pro #2482
Comments
@usman-receeve from your main.log, it seems macports is trying to install as x86 and not arm, can you try installing like this and report back if anything changes?
|
We also fail on "warning", so this might be what you're facing. :info:build /opt/local/var/macports/build/_Users_usmanirale_ports_multimedia_sunshine/Sunshine/work/Sunshine-0.23.1/src/platform/macos/av_audio.m:19:124: warning: 'AVCaptureDeviceTypeBuiltInMicrophone' is deprecated: first deprecated in macOS 14.0 [-Wdeprecated-declarations]
:info:build AVCaptureDeviceDiscoverySession *discoverySession = [AVCaptureDeviceDiscoverySession discoverySessionWithDeviceTypes:@[AVCaptureDeviceTypeBuiltInMicrophone,
:info:build ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build AVCaptureDeviceTypeMicrophone
:info:build /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVCaptureDevice.h:575:38: note: 'AVCaptureDeviceTypeBuiltInMicrophone' has been explicitly marked deprecated here
:info:build AVF_EXPORT AVCaptureDeviceType const AVCaptureDeviceTypeBuiltInMicrophone API_DEPRECATED_WITH_REPLACEMENT("AVCaptureDeviceTypeMicrophone", macos(10.15, 14.0), ios(10.0, 17.0), macCatalyst(14.0, 17.0)) API_UNAVAILABLE(tvos, visionos) API_UNAVAILABLE(watchos);
:info:build ^
:info:build /opt/local/var/macports/build/_Users_usmanirale_ports_multimedia_sunshine/Sunshine/work/Sunshine-0.23.1/src/platform/macos/av_audio.m:20:7: warning: 'AVCaptureDeviceTypeExternalUnknown' is deprecated: first deprecated in macOS 14.0 [-Wdeprecated-declarations]
:info:build AVCaptureDeviceTypeExternalUnknown]
:info:build ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
:info:build AVCaptureDeviceTypeExternal
:info:build /Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/System/Library/Frameworks/AVFoundation.framework/Headers/AVCaptureDevice.h:563:38: note: 'AVCaptureDeviceTypeExternalUnknown' has been explicitly marked deprecated here
:info:build AVF_EXPORT AVCaptureDeviceType const AVCaptureDeviceTypeExternalUnknown API_DEPRECATED_WITH_REPLACEMENT("AVCaptureDeviceTypeExternal", macos(10.15, 14.0)) API_UNAVAILABLE(ios, macCatalyst, tvos, visionos) API_UNAVAILABLE(watchos);
:info:build ^
:info:build [ 43%] Building CXX object CMakeFiles/sunshine.dir/src/platform/macos/display.mm.o
:info:build 2 warnings generated. You can try changing this line in your portfile:
to
I can't determine why you are getting those warnings though, and we don't get it in our CI... we both are using the same version of clang. |
Oh. That may help, still weird that's building on Rosetta instead of arm, from what I can tell from our logs our CI is building arm just ok, and there's no specific arch on portfile config. Even if the builds succeed, it shouldn't build for x86_64. Seems like an env issue to me.
@ReenigneArcher We are getting them too, it has to do with macOS 14+ framework, just kinda hidden on the CI, line 7000 or something of the "Install Sunshine" logs, but for some reason, not found in "build logs". I'll open a PR later to tackle those warnings, they are not an issue yet, but will be. |
I've seen something similar to the main issue here, I think on discord. I think that user had migrated their homebrew install from an x86_64 mac to an arm mac, and it was messing with things. |
I'm having an issue compiling using Homebrew on a M1 MacBook Pro. Should I start a new issue or add it here? I've included the make file with the relevant error. It's complaining that: But when I check homebrew config, it says it's using arm architecture. If I need to start a new issue, I can definitely do that. |
Same logs as yours. It seems that x86_64 Homebrew had messed up the openssl library search path in my m1 mac.
I solved the issue by unlinking the x86_64 openssl library, and maybe you can link the library back after the compilation.
|
I really appreciate the reply. Sadly, it doesn't look like that worked for me. I guess Homebrew is more messed up on this computer that I realized. This isn't my normal computer, I won't have access to that for a month or so. Guess I'll have to try again later. |
You shouldn't need to do this when using the brew formula, but this might help. https://docs.lizardbyte.dev/projects/sunshine/en/latest/building/macos.html#homebrew I have an idea to solve this though, through cmake. |
My fix made everything worse, lol: #2707 🤷♂️ |
same issues on Apple Silicon M1, macOS 14.5 (23F79) |
This has mostly to do with Rosetta shenanigans. With that said, I really have no idea for macports, but for brew I want to try something. I was wondering if finding the path of the brew dependency from inside brew, then forwarding it as an environment var to the compiler, yields better results, or even brew can't find the right one during install. If even brew can't find, I'm afraid it is a Rosetta/brew/ports issue and we can't do much. @ReenigneArcher so technically speaking, I'm thinking in doing something like I do here: Sunshine/packaging/sunshine.rb Lines 94 to 97 in aa2cf8e
And giving this path to the cmake, and maybe use it like you did in #2707, but ONLY with the path brew gave us, instead of having both potential paths there.
|
Sounds good. |
In fact, I fix this issue by unlinking the x86 openssl library. |
Been forwarded here from other issue. Could I ask what is wrong about my particular setup? Pasting logs from make as well. |
Closing in favor of a consolidated issue: #3180 Please add any pertinent information to that issue. |
Is there an existing issue for this?
Is your issue described in the documentation?
Is your issue present in the nightly release?
Describe the Bug
The compilation build process failed on macOS Sonoma 14.3
This is the main.log
Expected Behavior
No response
Additional Context
No response
Host Operating System
macOS
Operating System Version
Sonoma 14.3
Architecture
64 bit
Sunshine commit or version
0.23.1
Package
macOS - Portfile
GPU Type
n/a
GPU Model
Apple M2
GPU Driver/Mesa Version
Apple M2
Capture Method (Linux Only)
No response
Config
Apps
No response
Relevant log output
The text was updated successfully, but these errors were encountered: