Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tweaks the logic inside the emulator modules in order to let have have a uniform naming scheme for their functions.
Each emulator module will now have the following functions:
get_address() -> Address
: can be used at any point in an autosplitter to convert a game system's physical memory address to the corresponding memory address in the emulator process' virtual memory spacecheck_bounds() -> bool
: will check if a memory reading operation does not exceed the memory bounds of the emulated systemread::<T>
: As before, allows to read any value from the emulated RAMread_pointer_path::<T>
: valid only for 32bit systems and above, allows to resolve pointer pathsAdditionally, the specific commit for Genesis emulators also fixes #86