Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide, remove, or fix connecting to a websocket server #275

Closed
CryZe opened this issue Feb 29, 2020 · 10 comments · Fixed by #895
Closed

Hide, remove, or fix connecting to a websocket server #275

CryZe opened this issue Feb 29, 2020 · 10 comments · Fixed by #895
Labels
bug There's a bug in LiveSplit One. UI The issue is about the user interface.

Comments

@CryZe
Copy link
Collaborator

CryZe commented Feb 29, 2020

The problem is that we are using https and that prevents you from connecting to anything that's not https. So you can't easily run a websocket server locally and connect to it. And so far this roughly uses the server protocol from the original LiveSplit (though kind of in reverse, as the client and the server in a way are swapped). It does not speak the new synchronization protocol that we want to build. Considering it also plays a prominent role in our sidebar at the moment, this is mostly just "wasting valuable space", because of how unusable it is at the moment. So I feel like we either should look into making it more usable somehow, move it into the settings menu, or just get rid of it entirely for now, as the synchronization protocol most likely will supersede it anyway.

@CryZe CryZe added bug There's a bug in LiveSplit One. needs further discussion / research There's further design decisions that need to be made in order to continue. UI The issue is about the user interface. labels Feb 29, 2020
@wooferzfg
Copy link
Member

For the synchronization protocol, will we be connecting to external servers (like Splits.io for example) instead of a local server?

@CryZe
Copy link
Collaborator Author

CryZe commented Feb 29, 2020

Yeah, though you can probably still specify a custom URL, so it could still be a local one, as long as you figure out how to deal with https (or there's some workaround we can do).

@CryZe
Copy link
Collaborator Author

CryZe commented Jan 17, 2021

Looks like people are really confused by this. They are now trying to connect the OBS plugin and the original LiveSplit to the Web LSO. We really need to get rid of this (maybe at least move it to the settings instead of this prominently in the sidebar).

@DarkRTA
Copy link
Contributor

DarkRTA commented Jan 17, 2021

maybe at least move it to the settings instead of this prominently in the sidebar

Eh, I think we should just outright remove this. Any theoretical use case this currently has will be better done with LiveSplit One Desktop, and I don't know of anyone who's currently using this.

@CryZe
Copy link
Collaborator Author

CryZe commented Jan 17, 2021

I believe @thecodewarrior is using it though (#458, #459). But yes, I would otherwise completely remove it for now.

@DarkRTA
Copy link
Contributor

DarkRTA commented Jan 17, 2021

Apparently they are using it for a Celeste auto splitter.

https://github.com/thecodewarrior/SwiftSplit

@thecodewarrior
Copy link

thecodewarrior commented Jan 24, 2021

At the moment the websocket is the only way I'm aware of to create an autosplitter for macOS, so I would prefer it stay in. However, if it were replaced with something better that filled the same role I would gladly update SwiftSplit to use it.

Edit: The SSL hasn't been an issue using local connections for me. I can use wss://localhost without any SSL so far as I can tell.

@DarkRTA
Copy link
Contributor

DarkRTA commented Jan 24, 2021

At the moment the websocket is the only way I'm aware of to create an autosplitter for macOS, so I would prefer it stay in. However, if it were replaced with something better that filled the same role I would gladly update SwiftSplit to use it.

When LiveSplit/livesplit-core#176 is finished, it will much better fill this role than a completely undocumented WebSocket API. I see you've actually responded to that issue and have shown interest in helping on the macOS side of things so now might be a good time to start working on that. :)

@thecodewarrior
Copy link

Update on the SSL issue. I can't use wss://, but I can use ws:// without issue, but only in Firefox/Chrome. Safari is stricter about localhost and doesn't let it connect.

@CryZe
Copy link
Collaborator Author

CryZe commented Jan 29, 2021

Ah I heard that Firefox supposedly changed their policy towards localhost. Seems like Chrome might've done the same. Well if that's true, then that changes everything.

@CryZe CryZe added work in progress Someone is actively working on resolving this issue / implementing this pull request. and removed needs further discussion / research There's further design decisions that need to be made in order to continue. labels May 23, 2024
@CryZe CryZe linked a pull request May 27, 2024 that will close this issue
@CryZe CryZe removed the work in progress Someone is actively working on resolving this issue / implementing this pull request. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug There's a bug in LiveSplit One. UI The issue is about the user interface.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants