Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing a lot of docstrings #1

Open
LivInTheLookingGlass opened this issue May 1, 2021 · 5 comments
Open

Missing a lot of docstrings #1

LivInTheLookingGlass opened this issue May 1, 2021 · 5 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Milestone

Comments

@LivInTheLookingGlass
Copy link
Owner

Going to open a separate branch to slowly work on this, probably while I'm on a plane

@LivInTheLookingGlass LivInTheLookingGlass added documentation Improvements or additions to documentation good first issue Good for newcomers labels May 1, 2021
@prachipancholi
Copy link

Hey! I want to contribute, can you brief about the issue? @gappleto97

@LivInTheLookingGlass
Copy link
Owner Author

Sure! Basically I feel like if I am going to be providing methods that other people will have to do, I feel like I should be documenting it better than I have. That way they can be clear what they need to provide/should expect.

This puts me on three goals:

  1. Get this codebase set up with Sphinx so the documentation is gathered in a way that's easy to read
  2. Add docstrings to every function describing what it does, with what, and why, as well as what errors it could produce
  3. Add type hints to everything reasonable

Once that stuff is done, I'll feel better about adding features that are more than just polish.

If you want to help out, probably the easiest way is to just give you commit access to another branch I'll call docs, then I'll get the Sphinx environment set up enough to start. I don't think I can really start on this for a few days, but I could get that much set up tonight.

@LivInTheLookingGlass
Copy link
Owner Author

And if you don't mind me asking, how'd you find this? I don't think I've shown it to many people yet, so I was pleasantly surprised

@LivInTheLookingGlass LivInTheLookingGlass added this to the 1.0.0 milestone May 3, 2021
@prachipancholi
Copy link

And if you don't mind me asking, how'd you find this? I don't think I've shown it to many people yet, so I was pleasantly surprised

I got it from issuehub.io, where I was searching for my first contribution to Open Source

@LivInTheLookingGlass
Copy link
Owner Author

Okay, collab invite sent, docs branch made. Might need to add Sphinx's napoleon extension to make things pretty, but for now I'm just happy it makes a web page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants