Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Not-urgent] LF-4380 - address comments and improvement suggestions #3510

Merged
merged 10 commits into from
Dec 5, 2024
Merged

[Not-urgent] LF-4380 - address comments and improvement suggestions #3510

merged 10 commits into from
Dec 5, 2024

Commits on Oct 22, 2024

  1. LF-4380 Simplify setFalsyValuesToNull

    @Duncan-Brain
    Duncan-Brain committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    1b353cd View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. LF-4380 Add early return on breed checks

    @Duncan-Brain
    Duncan-Brain committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    00efca4 View commit details
    Browse the repository at this point in the history

  2. LF-4380 Remove excess checks on checkExactlyOneProvided for breed

    @Duncan-Brain
    Duncan-Brain committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    794c119 View commit details
    Browse the repository at this point in the history

  3. LF-4380 Separate out logic to clarify and avoid empty if statement

    @Duncan-Brain
    Duncan-Brain committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    003a3b7 View commit details
    Browse the repository at this point in the history

  4. LF-4380 Remove excessive existence checking

    @Duncan-Brain
    Duncan-Brain committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    b643951 View commit details
    Browse the repository at this point in the history

  5. LF-4380 Cannot remove not creating check as post does not allow null … 

    …values in oneOf schemas, update comments
    @Duncan-Brain
    Duncan-Brain committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    abdc72c View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2024

  1. LF-4380 Remove excess expect statements

    @Duncan-Brain
    Duncan-Brain committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    571f881 View commit details
    Browse the repository at this point in the history

  2. LF-4380 Improve tests

    @Duncan-Brain
    Duncan-Brain committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d700e1b View commit details
    Browse the repository at this point in the history

  3. Merge branch 'integration' into LF-4380-comments-and-improvements

    @Duncan-Brain
    Duncan-Brain committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    3d248ef View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. LF-4380 Update comment to complete sentence

    @Duncan-Brain
    Duncan-Brain committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    b13966c View commit details
    Browse the repository at this point in the history