-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: proper setting oldest/latest for integrations & PL>=1.9
#2129
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2129 +/- ##
======================================
Coverage 87% 87%
======================================
Files 293 293
Lines 16407 16415 +8
======================================
+ Hits 14253 14261 +8
Misses 2154 2154 |
@JustinGoheen @SkafteNicki seems the logging is different than expected for the latest PL (we have not tested it for long time 😿 ) mind have a look, pls: https://dev.azure.com/Lightning-AI/Metrics/_build/results?buildId=176883&view=logs&j=12a9e589-df1e-541c-f0d0-67a8d22922d8&t=b6423d8e-d265-5686-c4f1-df41b5bef40a&l=279 |
@awaelchli @justusschock, any ringing belts that could be the reason for the case failing... |
for more information, see https://pre-commit.ci
PL>=1.9
Setting the upper bound for
|
What does this PR do?
Integrations on GPU were strangely set always oldest req.
Dropped compatibility with:
1.6
- no special reason, but the next two versions wont work so skip also this old one1.7
- Pl was looking for removed protected function,ERROR integrations/test_lightning.py - ImportError: cannot import name '_compare_version' from 'torchmetrics.utilities.imports'
1.8
- not aligned dependencies:Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2129.org.readthedocs.build/en/2129/