Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check typos & fixing some... #2102

Merged
merged 10 commits into from
Sep 26, 2023
Merged

check typos & fixing some... #2102

merged 10 commits into from
Sep 26, 2023

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 22, 2023

What does this PR do?

fixing typos and preventing adding new...

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--2102.org.readthedocs.build/en/2102/

@Borda
Copy link
Member Author

Borda commented Sep 22, 2023

seems it replaces quite aggressively and also messes with source-code keywords... 😢

@Borda Borda mentioned this pull request Sep 22, 2023
4 tasks
@Borda Borda closed this in #2103 Sep 26, 2023
@Borda Borda mentioned this pull request Sep 26, 2023
4 tasks
@Borda
Copy link
Member Author

Borda commented Sep 26, 2023

Let's check how to configure it in pyproject.toml so we do not add too many new configs, ref: crate-ci/typos#790 (comment) -> crate-ci/typos#834

@Borda
Copy link
Member Author

Borda commented Sep 26, 2023

Let's wait till #2112 is merged to continue... 🐿️

@Borda Borda marked this pull request as ready for review September 26, 2023 11:37
@SkafteNicki SkafteNicki added the documentation Improvements or additions to documentation label Sep 26, 2023
@SkafteNicki SkafteNicki added this to the v1.2.x milestone Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #2102 (e72b588) into master (9aecaf4) will decrease coverage by 17%.
The diff coverage is 100%.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #2102     +/-   ##
========================================
- Coverage      87%     70%    -17%     
========================================
  Files         293     293             
  Lines       16299   16299             
========================================
- Hits        14159   11338   -2821     
- Misses       2140    4961   +2821     

@Borda Borda enabled auto-merge (squash) September 26, 2023 12:20
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Sep 26, 2023
@Borda Borda disabled auto-merge September 26, 2023 15:12
@Borda Borda merged commit 1ddacab into master Sep 26, 2023
57 of 61 checks passed
@Borda Borda deleted the ci/typos branch September 26, 2023 15:29
@mergify mergify bot added the ready label Sep 26, 2023
Borda added a commit that referenced this pull request Nov 30, 2023
(cherry picked from commit 1ddacab)
Borda added a commit that referenced this pull request Dec 1, 2023
(cherry picked from commit 1ddacab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants