-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory usage for certain image metrics #2089
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SkafteNicki
requested review from
Borda,
justusschock and
stancld
as code owners
September 23, 2023 17:14
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2089 +/- ##
========================================
- Coverage 87% 41% -46%
========================================
Files 293 293
Lines 16299 16327 +28
========================================
- Hits 14177 6629 -7548
- Misses 2122 9698 +7576 |
Borda
reviewed
Sep 25, 2023
Borda
approved these changes
Sep 25, 2023
stancld
approved these changes
Oct 1, 2023
Borda
pushed a commit
that referenced
this pull request
Nov 30, 2023
(cherry picked from commit 51439e6)
Borda
pushed a commit
that referenced
this pull request
Dec 1, 2023
(cherry picked from commit 51439e6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #2078
For
SpectralAngleMapper
andUniversalImageQualityIndex
the use of list state is not necessary forsum
andmean
reductions, and using tensor states instead in these cases are more memory efficient.The unittests are still covering that the calculations are correct.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃
📚 Documentation preview 📚: https://torchmetrics--2089.org.readthedocs.build/en/2089/