Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_tinyllama issue with LitData and iterate_over_all #1399

Closed
Andrei-Aksionov opened this issue May 8, 2024 · 2 comments · Fixed by #1404
Closed

test_tinyllama issue with LitData and iterate_over_all #1399

Andrei-Aksionov opened this issue May 8, 2024 · 2 comments · Fixed by #1404

Comments

@Andrei-Aksionov
Copy link
Collaborator

Hi there 👋

Apparently there is an issue with tinyllama test and the newest version of LitData (0.2.6).
In the release notes one can see that iterate_over_all has just been added:

Add support for iterate_over_all for the CombinedDataset by @tchaton in Lightning-AI/litdata#122

and that's why the issue didn't appear before.

Don't know whether this issue is on LitGPT or LitData side.
Maybe @awaelchli has any thoughts?

@awaelchli
Copy link
Contributor

awaelchli commented May 8, 2024

LitData made the decision to enforce iterate_over_all by default as a breaking change. LitGPT will have to set iterate_over_all=False explicitly now and require litdata>=0.2.6. The error message needs to be fixed though.

@tchaton
Copy link

tchaton commented May 9, 2024

Yes, the default behaviour was confusing to some users. It felt more natural all the samples should be seen, especially when used for computing the validation metrics.

As @awaelchli shared, let's add iterate_over_all to LitGPT where needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants