-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LitData doesn't support s3 bucket connection outside server #183
Comments
Hi! thanks for your contribution!, great first issue! |
Hey @sanyalsunny111, I am not sure I fully understand the issue. |
Could you provide the concrete code snippets and file paths (and studio names) to illustrate this to @tchaton with a concrete example to follow @sanyalsunny111 |
acknowledged I will do it shortly. |
@tchaton So, some dataset is uploaded to a publicly accessible s3 bucket and also in data prep of some teamspace. Now that I have tried to access this data using studio's public prod profile. However when I am trying to use the same data using s3 (yes I have configured through aws cli) or teamspace I couldn't access it. Below it a screenshot where it is asking for an access key. |
Hey @sanyalsunny111. Can you share a reproducible script ? |
Sure @tchaton I am using litgpt w/ no changes. Here is a loom video I recorded |
Hey @sanyalsunny111 Any Studio I can duplicate ? |
here /thunder/Experiments-Sunny2024 |
@tchaton Luca made some modifications and for me it is working fine now. Thought of updating you. He changed below mentioned lines in /home/zeus/miniconda3/envs/cloudspace/lib/python3.10/site-packages/litdata/streaming/client.py
|
Hey @sanyalsunny111. Can you make a PR with the fix ? |
🚀 Feature
LitData should support s3 bucket connection for streaming data outside of the same server.
Motivation
Current LitData supports s3 bucket connection for within public prod server but not outside of that for instance a GCP server.
Additional context
Sebastian and Adrian motivated me to raise this issue.
The text was updated successfully, but these errors were encountered: