Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add s3 path support to optimize (read and write to s3) #104

Closed
rakro101 opened this issue Apr 22, 2024 · 5 comments
Closed

Please add s3 path support to optimize (read and write to s3) #104

rakro101 opened this issue Apr 22, 2024 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rakro101
Copy link
Contributor

🚀 Feature

add s3 path support to optimize function

Motivation

To directly read and write to s3

Pitch

I want be able to add path from s3 to the optimize function and that the optimize function and direcly output to s3.

Alternatives

None

Additional context

None

@rakro101 rakro101 added enhancement New feature or request help wanted Extra attention is needed labels Apr 22, 2024
@tchaton
Copy link
Collaborator

tchaton commented May 7, 2024

Hey @rakro101,

Would you be interested in making a contribution ?

Best,
T.C

@rakro101
Copy link
Contributor Author

rakro101 commented May 7, 2024

Hey @tchaton,

Edit: Writing to s3 from local works.

ATM I looking at reading from s3.

For the contribution I have to talk to my boss. I will come back to you.

Bests
rakro101

@rakro101
Copy link
Contributor Author

rakro101 commented May 7, 2024

Solved with the S3Path Lib and some Modifications etc can read and write from
and to S3. @tchaton should add this to the studio? Maybe not this branch because optimize function can do it.

@rakro101 rakro101 closed this as completed May 7, 2024
@tchaton
Copy link
Collaborator

tchaton commented May 7, 2024

Hey @rakro101. Anything you can upstream to this repo ?

@rakro101
Copy link
Contributor Author

rakro101 commented May 7, 2024

No, optimize is able to read and write to s3, we had to modify the input function, https://lightning.ai/lightning-ai/studios/convert-parquets-to-lightning-streaming?section=data+processing : convert_parquet_to_lightning_data(parquet_file) not the optimize itself. This is why i closed the issue @tchaton. Thank you for the great implementation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants