-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language to ia metadata #161
Conversation
So this looks correct, and I could deploy this on the staging server. @twinkietoes-on, if I deploy this on the staging server, would you be able to try uploading a few test files, to see if the language correctly appears in the metadata of the uploaded items? Edit: So actually I've just gone ahead and deployed it, you can test at your own time :) |
I'll have to remind myself how to do it. I'll BCC Jo on this email; maybe she will help test.
On Saturday, April 15, 2023 at 11:41:46 a.m. EDT, Artom Lifshitz ***@***.***> wrote:
So this looks correct, and I could deploy this on the staging server. @twinkietoes-on, if I deploy this on the staging server, would you be able to try uploading a few test files, to see if the language correctly appears in the metadata of the uploaded items?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I got into the test server and uploaded this project (saying it was Spanish): https://archive.org/details/joy_other_poems_2304_librivox |
@twinkietoes-on thank you for testing this! I don't see the |
https://archive.org/download/joy_other_poems_2304_librivox/joy_other_poems_2304_librivox_meta.xml Is where the metadata should appear, and it shows that it was updated with the recent date time: For Spanish I would expect the 3-letter code |
Lemme play around with the code on the staging server, now that I have a project to use for testing, and have figured out where the "upload to archive.org" button is :) |
I'm going to delete that test project from Archive, unless anyone has an objection. Let me know before 8 pm Eastern if you do (in 32 minutes)
On Tuesday, April 18, 2023 at 07:05:16 p.m. EDT, Charles Horn ***@***.***> wrote:
https://archive.org/download/joy_other_poems_2304_librivox/joy_other_poems_2304_librivox_meta.xml Is where the metadata should appear, and it shows that it was updated with the recent date time: 2023-04-18 16:28:27. x-archive-meta-language: is the correct way to send the metadata using the ias3 API as documented here: https://archive.org/developers/ias3.html ... so I think the code is correct for this part.
For Spanish I would expect the 3-letter code spa to be sent. If something was wrong it might get set to the default eng, I'm surprised it's not being set at all though.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
OK, that was my bad, when @twinkietoes-on first tested in the staging environment, the wrong branch was checked out. When I attempted it again, I used the same project (https://archive.org/details/joy_other_poems_2304_librivox), and it looks like once uploaded, any further upload attempts do not change the metadata. I then tried again with https://archive.org/details/joy_other_poems_2304_librivox_second and https://archive.org/details/joy_other_poems_2304_librivox_third, and in both cases the language shows up correctly, so I think we're good. @twinkietoes-on can you please delete all those testing projects from archive? |
Will do!
On Tuesday, April 18, 2023 at 08:43:54 p.m. EDT, Artom Lifshitz ***@***.***> wrote:
Merged #161 into master.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
The German ones are showing up as the 3-letter code, deu. |
@twinkietoes-on archive.org has flexible, but unfortunately somewhat inconsistent handling of language codes. The preferred 3 letter code is from the MARC language code list, but ISO 639-3 and ISO 639-2 are also generally supported.
My feeling is that archive.org should handle ISO 639-3 better, rather than librivox have to translate the codes. Librivox seems to be consistent with its ISO 3 letter language codes, which work well. Many other archive.org items have ISO 639-3 codes already. |
closes #8
and partially #132
I'd like it if there was a 3 letter language code rather than a full name. (Hopefully done now with 42f73de)
Some of the existing code suggests there is a
3_letter_code
(https://github.com/LibriVox/librivox-catalog/search?q=three_letter_code) , but I'm not completely sure whether this is guaranteed to exist, or where it comes from.The archive.org fields to target are:
If I can determine a good source -> destination mapping, I can very likely make retrospective updates to the existing archive.org items happen.
I have not tested this code yet (not sure the best way to do so).