Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make audio and Archive links https (WIP: see description) #133

Open
twinkietoes-on opened this issue Dec 28, 2021 · 2 comments
Open

Make audio and Archive links https (WIP: see description) #133

twinkietoes-on opened this issue Dec 28, 2021 · 2 comments

Comments

@twinkietoes-on
Copy link
Collaborator

Hi Artom,

Coming back to this since I am still getting this issue of failed downloads due to mixed content reported via [email protected].

For the existing projects (as of when you made the changes to fix the http to https links), the previously cataloged project archive page links were changed to https, but for projects cataloged since then, they are still going in as http. Similarly (but in reverse), the individual audio file links for recently cataloged pages are https, but the links to the audio files on previously cataloged pages were not changed from http to https.

When you have time, can you use your script to run a fix on these additional fields in the database so that every link to individual files and to archive (existing and new) are entered as https?

Tricia and I discussed this by PM a while ago, but I haven't looked to see if it was added as a request in github.

@notartom
Copy link
Member

Do we have an example page that has a mixed context warning? There are a bunch of URLs sprinkled all over the database, and I didn't update them all, so it would help to see the error from the user's POV, so that I know what I need to track down in the database.

@redrun45
Copy link
Collaborator

As of the most recent database dump, I believe all of the audio and image URLs used in the catalog are HTTPS. There shouldn't be any mixed content warnings anymore. 😃

We do still have a bunch of external links that are HTTP and which could be updated sometime but isn't pressing at all. For example, project 19677's url_text_source is 'http://www.gutenberg.org/etext/26000', which redirects to HTTPS without any errors.

I'm going to set this to 'priority:low'. If I could add tags, I'd stick this one with 'database cleanup' as well. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants