-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace dashes with underscores #307
Comments
Great suggestion @ndporter - thank you 🙏 If anyone is willing / able to check through the lesson and identify any other examples, or even better make the edits for the maintainers to then approve that would be amazing. This tutorial shows how you can show us the exact line and make the edit for maintainers to approve |
I won't have a chance to do this in the near future, or I would have put in a PR myself. I will also note that images may need to be changed to be consistent with the text (including the example I identified). |
I'll add a note to also make the hyphen in User-Agent an underscore. And a question: Might this be an instructor note in addition to the text edits? Also, what does the alt-text need to be? it is currently: Does the alt-text need to describe what the image looks like (but doesn't need to repeat preceding or following instructions): |
If you meant the HTTP header: that should be a hyphen. |
Good catch @bencomp it's important to only change the column headers we create, not the data we're trying to pass through the API, whose structure is determined by the providers. |
Replaced "-" with "_"
LibraryCarpentry#307 Update 13-looking-up-data.md
#307 Replace dashes with underscores (13-looking-up-data.md)
Auto-generated via {sandpaper} Source : 1aef633 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-08-28 16:13:12 +0000 Message : Merge pull request #310 from mahdi-robbani/main #307 Replace dashes with underscores (13-looking-up-data.md)
Auto-generated via {sandpaper} Source : a2e24f0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-08-28 16:14:37 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 1aef633 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-08-28 16:13:12 +0000 Message : Merge pull request #310 from mahdi-robbani/main #307 Replace dashes with underscores (13-looking-up-data.md)
Column names in "Looking up data" episode fixed by #310. Waiting on confirmation from @mahdi-robbani whether a review of all episodes was included in that work |
Auto-generated via {sandpaper} Source : a2e24f0 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-08-28 16:14:37 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 1aef633 Branch : main Author : Owen Stephens <[email protected]> Time : 2023-08-28 16:13:12 +0000 Message : Merge pull request #310 from mahdi-robbani/main #307 Replace dashes with underscores (13-looking-up-data.md)
Confirmed that #310 only addresses the Looking up data episode, so there is still a task here to check if there are any column names that are not appropriately formatted in any other episodes |
Have added #314 for the user-agent/http header issue |
Remaining tasks for this issue:
|
Following best practices (see TidyData lesson column headers being created should use
_
instead of-
whenever possible. This applies at least to Looking up Data (e.g.,Journal-details
) but other episodes should be checked as well for consistency.The text was updated successfully, but these errors were encountered: