Dependency updates #128
Dependency updates #128
Conversation
| with: | ||
| node-version: '18.18.2' | ||
|
|
||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
actions/setup-node@v4 has this included
| registry-url: 'https://registry.npmjs.org' | ||
|
|
||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
actions/setup-node@v4 has this included
| registry-url: 'https://registry.npmjs.org' | ||
|
|
||
| - uses: actions/cache@v2 |
There was a problem hiding this comment.
actions/setup-node@v4 has this included
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "$schema": "https://json.schemastore.org/mocharc.json", | |||
| "require": "tsx" | |||
There was a problem hiding this comment.
Switching to tsx only requires this!
| @@ -1,5 +1,5 @@ | |||
| // | |||
| // Autogenerated by Thrift Compiler (0.16.0) | |||
| // Autogenerated by Thrift Compiler (0.18.1) | |||
There was a problem hiding this comment.
I did regen these files with v0.18.1, but nothing was different except this header.
| // BSON uses top level awaits, so use require for now | ||
| const bsonSerialize = require('bson').serialize; | ||
| const bsonDeserialize = require('bson').deserialize; |
There was a problem hiding this comment.
Really annoying and only impacts esbuild for the browser, but not too bad.
Why the double require? It was clearer than the named version and keeps the linter away from trying to reformat it.
test/mocks/handlers.js
Outdated
There was a problem hiding this comment.
These were updates for the new version of msw. No big changes however
| @@ -12,15 +12,11 @@ | |||
| "sourceMap": false, | |||
| "strict": true, | |||
| "target": "ESNext", | |||
| "watch": false, | |||
There was a problem hiding this comment.
This never did anything.
| "ts-node": { | ||
| "files": true | ||
| } |
There was a problem hiding this comment.
I got this error on cd examples && npm i && node app.js:
node:internal/modules/cjs/loader:1080
throw err;
^
Error: Cannot find module '/Users/shannonwells/github/parquetjs/examples/app.js'
at Module._resolveFilename (node:internal/modules/cjs/loader:1077:15)
at Module._load (node:internal/modules/cjs/loader:922:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:86:12)
at node:internal/main/run_main_module:23:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
| import { Options } from "./codec/types"; | ||
| import type { Document as BsonDocument } from "bson"; | ||
| // BSON uses top level awaits, so use require for now | ||
| const bsonSerialize = require('bson').serialize; |
Updated almost all of the dependencies to the latest version.
mswbreaking changes, but nothing special for our use cases.Suggested Tests
npm i && npm run build && npm run servecd examples/server && npm i && node app.jshttp://localhost:3000, open up the console and hit some buttons.