Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merlin SIM fails w/ many files and memfd #79

Open
sk1p opened this issue Apr 12, 2023 · 0 comments
Open

Merlin SIM fails w/ many files and memfd #79

sk1p opened this issue Apr 12, 2023 · 0 comments
Labels
bug Something isn't working detector:merlin

Comments

@sk1p
Copy link
Member

sk1p commented Apr 12, 2023

Debugging with @matbryan52: if the Merlin dataset has many files (thousands), it will exhaust the number of file descriptors available by default. Increasing the limit can then cause another issue, as we are using select to check for connection abortions, and select only supports file descriptors in [0, 1024).

Why we are using select: Windows. See commit ec9953c

Possible fix is to keep using select on Windows, and switch to the previous implementation using poll or epoll for Linux, which works properly for "high" file descriptor numbers.

@sk1p sk1p added bug Something isn't working detector:merlin labels Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working detector:merlin
Projects
None yet
Development

No branches or pull requests

1 participant