Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User interface #55

Open
sk1p opened this issue Mar 13, 2024 · 1 comment
Open

User interface #55

sk1p opened this issue Mar 13, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@sk1p
Copy link
Member

sk1p commented Mar 13, 2024

We should have a user interface for some of the possibly interactive parts. It should be fine to have this in a notebook, as that's what users are already familiar with. We should use LiberTEM-panel-ui by @matbryan52 for this purpose.

Ideas about workflows with interactivity:

  • Building the aperture
    • Include a preview reconstruction for the first hologram in the stack
    • FFT view which shows the selected aperture over the FFT of the first frame
    • Could also include a slider to preview different frames
    • Tweaking the sideband position. Usually the estimated position should work, but the user may want to move it
    • Additional mask tweaks, like adding a line filter (or maybe more generally editing the shape of the aperture, if needed)
  • Registration and averaging
    • Selection of the area/slice on which the registration should be run
    • Should be possible to scrub through both the original stack and the aligned stack, and view the averaged result
    • Possibly manually adjust single shift vectors where the auto-alignment failed? Can we cross-check the aligned stack with some similarity measure for finding alignment issues?
  • Phase unwrapping
    • Include a manual phase rotation, for example to move phase jumps out of the sample area

For all of these, it should be possible to extract the interactively determined parameters such that a non-interactive script reproducing the whole reconstruction can be published alongside the original data.

For the interactive use-case, it could pay off to make sure computations happen on the GPU, to get good per-hologram performance for the previews.

@sk1p sk1p added the enhancement New feature or request label Mar 13, 2024
@matbryan52
Copy link
Member

As mentioned elsewhere this should all be feasible with https://github.com/LiberTEM/LiberTEM-panel-ui/ without too much effort. I do need to check again that that repo still functions correctly with an up-to-date Panel / Bokeh.

I have time on Wednesday and Thursday if you want to look at this this week ! Otherwise we can organise something soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants