-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade MiniO Chart to 14.7.15 #238
base: main
Are you sure you want to change the base?
Conversation
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
65ffd4e
to
1284e66
Compare
This commit upgrdes MiniO charts to the latest 14.8.6 version. Including updating the image tag to install the latest MiniO.
1284e66
to
60f65a2
Compare
Reviewer's Guide by SourceryThis PR upgrades the MinIO chart dependency and associated container images. The implementation involves updating version numbers in both Chart.yaml and values.yaml files, specifically upgrading the MinIO chart version and updating the container image tags to use newer Debian 12-based releases. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ching-kuo - I've reviewed your changes - here's some feedback:
Overall Comments:
- There's a discrepancy between the PR title (14.7.15) and the actual Chart.yaml update (14.8.6). Please update the PR title to reflect the correct version.
- The addition of the persistence.mountPath parameter is not mentioned in the PR description. Please update the description to include all changes being made.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
User description
This commit upgrdes MiniO charts to the latest 14.8.6 version. Including updating the image tag to install the latest MiniO.
PR Type
enhancement
Description
minio
dependency to version14.7.15
inChart.yaml
.minio.image.tag
andminio.clientImage.tag
to2024.10.2-debian-12-r0
invalues.yaml
.Changes walkthrough 📝
Chart.yaml
Update MinIO Dependency Version in Chart.yaml
charts/agh3/Chart.yaml
minio
dependency version from12.2.4
to14.7.15
.values.yaml
Update MinIO Image Tags in values.yaml
charts/agh3/values.yaml
minio.image.tag
from2023.3.24
to2024.10.2-debian-12-r0
.minio.clientImage.tag
from2023.4.12
to2024.10.2-debian-12-r0
.Summary by Sourcery
Upgrade the MinIO chart to version 14.8.6 and update the image tags in values.yaml to the latest versions.
Enhancements: