refactor/remove unused service #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
knowlet
commented
Nov 8, 2023
knowlet
commented
- refactor: delete unused files and templates
- refactor: update deployment configurations
- refactor: update image pull policy configuration
- ci: update test.yml and update-value.yml
- ci: add chart-linting step
Deleted the attack-related files, including attack-db-secret.yml, attack-deployment.yml, attack-service.yml, attack-ui-deployment.yml, attack-ui-service.yml. This change removes the attack functionality from the codebase.
This commit updates the deployment configurations for the UI, Captain, and Core components. The changes include refactoring the ingress route for the UI component and adjusting the environment variables for the Captain and Core components. Additionally, unnecessary environment variables for the Core component have been removed.
- Remove unnecessary code for returning image names in _helpers.tpl file. - Remove unused parameters and configurations for AGH2-ATTACK, AGH2-Blender, AGH2-Matcher, AGH2-Template, and AGH2-Transformer in values.yaml file. These changes improve the code and remove unnecessary configurations.
The commit message summarizes the changes made in the code: - In test.yml, the "--set attack.enabled=false" line was removed. - In update-value.yml, several lines related to environment variables (attack, blender, matcher, template, transformer) were removed. This information is provided in a concise and informal tone within the character limit of 50 characters.
A new step has been added to the workflow to run chart-linting on charts/agh2 before running chart-testing.
Aries0d0f
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.