#91 inline-edit HTML is componentized #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brauliodiez
reviewed
Aug 8, 2024
| }, | ||
| }} | ||
| > | ||
| <Element |
There was a problem hiding this comment.
I would rather use conditional rendering here, reasons why:
- It's clearer that you are using a textarea or input
- In the future we could have more editable inputs with different signatures.
brauliodiez
reviewed
Aug 8, 2024
| @@ -0,0 +1,37 @@ | |||
| import { Html } from 'react-konva-utils'; | |||
There was a problem hiding this comment.
Place this in a subfolder
src/common/components/inline-edit/components/html-edit.widget.tsx
and add a barrel
…folder components
|
conditional rendering added |
brauliodiez
deleted the
feature/#91-componentize-inline-edit-to-avoid-complexity-on-HTML
branch
jsanzdev
added a commit
that referenced
this pull request
Aug 20, 2024
- Added SVGs for Copy and Paste buttons - Created individual components to handle SVGs. - Created copy-pasted-button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Componentized the HTML Konva element into a new file named "html-edit.widget.tsx"
Also added a model file for types and interfaces
closes #91