Change default image_mode to proxy, remove deprecated option #5176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
Nutomic
force-pushed
the
image-mode-changes
branch
from
6d3fc73
to
7f294a8
Compare
5 tasks
Nutomic
force-pushed
the
image-mode-changes
branch
from
7f294a8
to
75a5c3e
Compare
Nutomic
force-pushed
the
image-mode-changes
branch
from
656f35a
to
8549972
Compare
|
I'd also be fine with removing the We should probably leave as draft until we make sure lemmy.ml doesn't have any issues with it, as well as any federation problems. |
|
#4874 seems like one of the things that probably should be addressed before proxying becomes the default |
Nutomic
force-pushed
the
image-mode-changes
branch
4 times, most recently
from
ada012e
to
793de63
Compare
Nutomic
force-pushed
the
image-mode-changes
branch
from
793de63
to
2b2995f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would also consider deprecating/removing the option
StoreLinkPreviewsas proxying can achieve the same purpose much more efficiently.Besides we should enable image proxying on lemmy.ml to ensure that it works well.