-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forward lc0's stderr to lc0-client's stderr #10
Comments
It already does this: go func() {
stderrScanner := bufio.NewScanner(stderr)
for stderrScanner.Scan() {
fmt.Printf("%s\n", stderrScanner.Text())
}
}() |
That's weird because I don't see things like that:
in lc0-client's output. Also maybe instead of doing that manually, there's a way to do that automatically? (in python it's certainly possible to somehow share stderr with subprocess when creating one). |
are you on windows? I see those lines in linux |
I submitted a PR to hopefully reduce the potential loss of such messages (which are definitely working on windows) by connecting lc0 stderr directly to stdout of client rather than using the goroutine. |
It would be nice to show entire lc0 stderr output when running client, for example by displaying it on lc0-client's stderr. That way when something is wrong with lc0 it can be seen.
The text was updated successfully, but these errors were encountered: