From 6e0586aae6069a3f284339eeae9ec01d9a026e34 Mon Sep 17 00:00:00 2001
From: jdabbech-ledger <jalil.dabbech@ledger.com>
Date: Wed, 27 Dec 2023 15:59:36 +0100
Subject: [PATCH] chore: clean .gitkeep & review

---
 packages/config/typescript/package.json   | 2 +-
 packages/core/src/api/.gitkeep            | 0
 packages/core/src/api/DeviceSdk.ts        | 6 +++++-
 packages/core/src/api/DeviceSdkBuilder.ts | 1 -
 packages/core/src/transport/.gitkeep      | 0
 packages/signer/src/.gitkeep              | 0
 packages/trusted-apps/src/.gitkeep        | 0
 packages/ui/src/.gitkeep                  | 0
 8 files changed, 6 insertions(+), 3 deletions(-)
 delete mode 100644 packages/core/src/api/.gitkeep
 delete mode 100644 packages/core/src/transport/.gitkeep
 delete mode 100644 packages/signer/src/.gitkeep
 delete mode 100644 packages/trusted-apps/src/.gitkeep
 delete mode 100644 packages/ui/src/.gitkeep

diff --git a/packages/config/typescript/package.json b/packages/config/typescript/package.json
index 75d555cb3..d65deacf5 100644
--- a/packages/config/typescript/package.json
+++ b/packages/config/typescript/package.json
@@ -8,9 +8,9 @@
   ],
   "devDependencies": {
     "@tsconfig/recommended": "^1.0.3",
+    "@types/eslint": "^8.44.9",
     "@types/node": "^20",
     "@types/react": "^18",
-    "@types/eslint": "^8.44.9",
     "@types/react-dom": "^18"
   }
 }
diff --git a/packages/core/src/api/.gitkeep b/packages/core/src/api/.gitkeep
deleted file mode 100644
index e69de29bb..000000000
diff --git a/packages/core/src/api/DeviceSdk.ts b/packages/core/src/api/DeviceSdk.ts
index 06b71cc4a..48b35004a 100644
--- a/packages/core/src/api/DeviceSdk.ts
+++ b/packages/core/src/api/DeviceSdk.ts
@@ -4,7 +4,11 @@ export class DeviceSdk {
     console.log("Hello world");
   }
 
-  scan() {
+  startScan() {
+    return;
+  }
+
+  stopScan() {
     return;
   }
 }
diff --git a/packages/core/src/api/DeviceSdkBuilder.ts b/packages/core/src/api/DeviceSdkBuilder.ts
index ebe31a742..96e058aa1 100644
--- a/packages/core/src/api/DeviceSdkBuilder.ts
+++ b/packages/core/src/api/DeviceSdkBuilder.ts
@@ -1,7 +1,6 @@
 import { DeviceSdk } from "./DeviceSdk";
 
 export class LedgerDeviceSdkBuilder {
-  //props
   constructor() {
     console.log("New build");
   }
diff --git a/packages/core/src/transport/.gitkeep b/packages/core/src/transport/.gitkeep
deleted file mode 100644
index e69de29bb..000000000
diff --git a/packages/signer/src/.gitkeep b/packages/signer/src/.gitkeep
deleted file mode 100644
index e69de29bb..000000000
diff --git a/packages/trusted-apps/src/.gitkeep b/packages/trusted-apps/src/.gitkeep
deleted file mode 100644
index e69de29bb..000000000
diff --git a/packages/ui/src/.gitkeep b/packages/ui/src/.gitkeep
deleted file mode 100644
index e69de29bb..000000000