From 5ea00063d8c507449bcc427b4688b8123b46063d Mon Sep 17 00:00:00 2001 From: jdabbech-ledger Date: Thu, 4 Jan 2024 17:12:21 +0100 Subject: [PATCH] chore(setup): review --- .github/workflows/pull_request.yml | 3 --- .gitignore | 3 ++- package.json | 12 ++++----- packages/config/eslint/package.json | 3 +-- packages/core/scripts/add-feature.mjs | 2 -- packages/core/src/transport/model/Response.ts | 5 +--- packages/core/src/transport/model/index.ts | 2 +- pnpm-lock.yaml | 27 +++---------------- 8 files changed, 14 insertions(+), 43 deletions(-) diff --git a/.github/workflows/pull_request.yml b/.github/workflows/pull_request.yml index 172405300..a25ae9faa 100644 --- a/.github/workflows/pull_request.yml +++ b/.github/workflows/pull_request.yml @@ -15,11 +15,8 @@ jobs: - uses: pnpm/action-setup@v2 name: Install pnpm - with: - run_install: false - name: Get pnpm store directory - shell: bash run: | echo "STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV diff --git a/.gitignore b/.gitignore index f13922b16..0c5819f92 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,7 @@ node_modules # IDE .idea +.vscode *.iml # misc @@ -32,4 +33,4 @@ lib .turbo # eslint -.eslintcache \ No newline at end of file +.eslintcache diff --git a/package.json b/package.json index 801d90ec5..a770087d4 100644 --- a/package.json +++ b/package.json @@ -12,18 +12,18 @@ "dev": "turbo dev", "lint": "turbo run lint", "lint:fix": "turbo run lint:fix", - "core": "turbo --filter @ledgerhq/device-sdk-core", - "signer": "turbo --filter @ledgerhq/device-sdk-signer", - "trusted-apps": "turbo --filter @ledgerhq/device-sdk-trusted-apps", - "ui": "turbo --filter @ledgerhq/device-sdk-ui", - "sample": "turbo --filter @ledgerhq/device-sdk-sample", + "core": "pnpm --filter @ledgerhq/device-sdk-core", + "signer": "pnpm --filter @ledgerhq/device-sdk-signer", + "trusted-apps": "pnpm --filter @ledgerhq/device-sdk-trusted-apps", + "ui": "pnpm --filter @ledgerhq/device-sdk-ui", + "sample": "pnpm --filter @ledgerhq/device-sdk-sample", "test": "echo \"Error: no test specified\" && exit 1" }, "devDependencies": { "@ledgerhq/eslint-config-dsdk": "workspace:*", "@ledgerhq/tsconfig-dsdk": "workspace:*", "lint-staged": "^15.2.0", - "path": "^0.12.7", + "prettier": "^3.1.1", "turbo": "^1.11.2", "eslint": "^8.56.0", "typescript": "^5.3.3", diff --git a/packages/config/eslint/package.json b/packages/config/eslint/package.json index 08444c4f8..498150738 100644 --- a/packages/config/eslint/package.json +++ b/packages/config/eslint/package.json @@ -12,7 +12,6 @@ "@vercel/style-guide": "^5.1.0", "eslint-config-prettier": "^9.1.0", "eslint-config-turbo": "^1.10.12", - "eslint-plugin-only-warn": "^1.1.0", - "prettier": "^3.1.1" + "eslint-plugin-only-warn": "^1.1.0" } } diff --git a/packages/core/scripts/add-feature.mjs b/packages/core/scripts/add-feature.mjs index 8e51c6b2a..25207352f 100644 --- a/packages/core/scripts/add-feature.mjs +++ b/packages/core/scripts/add-feature.mjs @@ -1,6 +1,4 @@ #!/usr/bin/env zx -import { basename } from 'path'; - const features = argv._; if (!features.length) { diff --git a/packages/core/src/transport/model/Response.ts b/packages/core/src/transport/model/Response.ts index 3644e8373..4c0b2b92a 100644 --- a/packages/core/src/transport/model/Response.ts +++ b/packages/core/src/transport/model/Response.ts @@ -1,4 +1 @@ - -export class Response { - -} \ No newline at end of file +export class Response {} diff --git a/packages/core/src/transport/model/index.ts b/packages/core/src/transport/model/index.ts index 7065f1f04..2f4d82263 100644 --- a/packages/core/src/transport/model/index.ts +++ b/packages/core/src/transport/model/index.ts @@ -1 +1 @@ -export { Response } from "./Response"; +export type { Response } from "./Response"; diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 48cc5f4d8..49e572cb7 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -20,9 +20,9 @@ importers: lint-staged: specifier: ^15.2.0 version: 15.2.0 - path: - specifier: ^0.12.7 - version: 0.12.7 + prettier: + specifier: ^3.1.1 + version: 3.1.1 turbo: specifier: ^1.11.2 version: 1.11.2 @@ -84,9 +84,6 @@ importers: eslint-plugin-only-warn: specifier: ^1.1.0 version: 1.1.0 - prettier: - specifier: ^3.1.1 - version: 3.1.1 packages/config/typescript: devDependencies: @@ -3503,13 +3500,6 @@ packages: engines: {node: '>=8'} dev: true - /path@0.12.7: - resolution: {integrity: sha512-aXXC6s+1w7otVF9UletFkFcDsJeO7lSZBPUQhtb5O0xJe8LtYhj/GxldoL09bBj9+ZmE2hNoHqQSFMN5fikh4Q==} - dependencies: - process: 0.11.10 - util: 0.10.4 - dev: true - /pause-stream@0.0.11: resolution: {integrity: sha512-e3FBlXLmN/D1S+zHzanP4E/4Z60oFAa3O051qt1pxa7DEJWKAyil6upYVXCWadEnuoqa4Pkc9oUx9zsxYeRv8A==} dependencies: @@ -3648,11 +3638,6 @@ packages: hasBin: true dev: true - /process@0.11.10: - resolution: {integrity: sha512-cdGef/drWFoydD1JsMzuFf8100nZl+GT+yacc2bEced5f9Rjk4z+WtFUTBu9PhOi9j/jfmBPu0mMEY4wIdAF8A==} - engines: {node: '>= 0.6.0'} - dev: true - /prop-types@15.8.1: resolution: {integrity: sha512-oj87CgZICdulUohogVAR7AjlC0327U4el4L6eAvOqCeudMDVU0NThNaV+b9Df4dXgSP1gXMTnPdhfe/2qDH5cg==} dependencies: @@ -4459,12 +4444,6 @@ packages: resolution: {integrity: sha512-EPD5q1uXyFxJpCrLnCc1nHnq3gOa6DZBocAIiI2TaSCA7VCJ1UJDMagCzIkXNsUYfD1daK//LTEQ8xiIbrHtcw==} dev: true - /util@0.10.4: - resolution: {integrity: sha512-0Pm9hTQ3se5ll1XihRic3FDIku70C+iHUdT/W926rSgHV5QgXsYbKZN8MSC3tJtSkhuROzvsQjAaFENRXr+19A==} - dependencies: - inherits: 2.0.3 - dev: true - /validate-npm-package-license@3.0.4: resolution: {integrity: sha512-DpKm2Ui/xN7/HQKCtpZxoRWBhZ9Z0kqtygG8XCgNQ8ZlDnxuQmWhj566j8fN4Cu3/JmbhsDo7fcAJq4s9h27Ew==} dependencies: