Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to support constructing manifests from multiple paths #2

Open
alice-i-cecile opened this issue Apr 14, 2024 · 4 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@alice-i-cecile
Copy link
Contributor

This is useful for working with dynamic loading and unloading.

It's not clear what the best path forward here is: simply passing in a vec of paths is too naive, and doesn't really properly cover the usage pattern where this would be useful.

@alice-i-cecile alice-i-cecile added enhancement New feature or request documentation Improvements or additions to documentation labels Apr 14, 2024
@alice-i-cecile
Copy link
Contributor Author

From the draft split_manifest example:

//! While it's simplest to simply define all elements of the manifest in a single file, it's also possible to split the manifest into multiple files.
//!
//! This can be useful to reduce merge conflicts in a team environment, keep things organized,
//! allow for more modular content creation by grouping the content into smaller files,
//! or reduce the amount of data that needs to be loaded into memory at once.
//!
//!
//! This example showcases a simple pattern for loading manifests from multiple files.

@edgarssilva
Copy link

edgarssilva commented Apr 21, 2024

Hi, I would like to make a question/feature request that might be related to this issue.

Using the provided example raw_items the raw manifest reads a Vec of items from a file asset.
How would one read a folder, or a list of files, where each file is one entry in the manifest as a RawItem?

In a situation where a RawItem has tons of fields and there is a huge variety of items, it can be rather bothersome to have it all in one file.

Also love the idea and see a lot of potential in it. Great job :)

@alice-i-cecile
Copy link
Contributor Author

Yep, this is precisely the sort of usage pattern I had in mind. Shouldn't be challenging technically: it's mostly a matter of API design. If you have a strong proposal, feel free to open a PR and we'll take a look!

@brandon-reinhart
Copy link
Contributor

My use case for this is that I'd like to be able to have mod authors insert their own manifests of a given type in a path and load those, merging items from their manifest into the game's runtime manifest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants