README nits + diagram #145
Open
+18
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmcgary
reviewed
Dec 10, 2024
seanmcgary
reviewed
Dec 10, 2024
seanmcgary
reviewed
Dec 10, 2024
| @@ -23,6 +23,21 @@ A core responsibility of the Sidecar is facilitating the calculations of [reward | |||
| * MacOS | |||
| * Linux (Ubuntu/Debian) | |||
|
|
|||
| # Diagram | |||
There was a problem hiding this comment.
Doesnt belong in this particular context. Eventually we'll have more detailed docs that show the architecture of the sidecar.
seanmcgary
reviewed
Dec 10, 2024
README.md
Outdated
| ``` | ||
|
|
||
| ```bash | ||
| # Example for holesky testnet |
There was a problem hiding this comment.
This comment is inaccurate since this request is relevant for both holesky and mainnet. Better to just leave it out entirely
nits
updated block number :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readme + diagram makes it easier to understand