Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to/small issues with communication #34

Open
clarkedavida opened this issue Dec 24, 2021 · 2 comments
Open

Improvements to/small issues with communication #34

clarkedavida opened this issue Dec 24, 2021 · 2 comments
Assignees
Labels
bug Something isn't working enhancement Improve or optimize existing feature high priority This needs urgent attention.

Comments

@clarkedavida
Copy link
Collaborator

  1. It would be useful to add a short test to the CommunicationBase setup. This way with each run we can be sure e.g. cuda-aware mpi and cuda p2p are working as intended.
  2. Apparently the current cuda-aware mpi check only checks if it's supported, rather than used. (A short-term fix to this could be to update the status text to say "supported" rather than "used".)
  3. There is a comment "We can only check this reliably for openmpi. TODO: find out how to do it for other mpi libraries" that needs to be resolved.
  4. the SpinorHaloTest reports FAILED when using cuda-awari mpi OFF in conjunction with cuda-p2p ON
@clarkedavida clarkedavida added bug Something isn't working enhancement Improve or optimize existing feature labels Dec 24, 2021
@luhuhis luhuhis added the high priority This needs urgent attention. label May 10, 2022
@luhuhis
Copy link
Collaborator

luhuhis commented Jun 29, 2022

It would be useful to add a short test to the CommunicationBase setup. This way with each run we can be sure e.g. cuda-aware mpi and cuda p2p are working as intended.

@lukas-mazur, wouldn't that be as simple as calling the functions run0 and run1 from main_cudaawareMPItest to CommunicationBase::init()?

@luhuhis
Copy link
Collaborator

luhuhis commented Jul 7, 2022

We could also somehow incorporate https://github.com/lukas-mazur/cudaAwareMPITest into the setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improve or optimize existing feature high priority This needs urgent attention.
Projects
None yet
Development

No branches or pull requests

3 participants