From 324f1458d5b6910294fbaba836f414d25bcf7cdc Mon Sep 17 00:00:00 2001
From: warriorstar-orion <orion@snowfrost.garden>
Date: Wed, 27 Nov 2024 12:14:41 -0500
Subject: [PATCH] fix: remove access-less helpers and add a maplint (#27462)

---
 _maps/map_files/shuttles/emergency_lance.dmm  |  6 +-
 _maps/map_files/stations/emeraldstation.dmm   |  4 +-
 .../maplint/lints/generic_access_helpers.yml  | 71 +++++++++++++++++++
 3 files changed, 76 insertions(+), 5 deletions(-)
 create mode 100644 tools/maplint/lints/generic_access_helpers.yml

diff --git a/_maps/map_files/shuttles/emergency_lance.dmm b/_maps/map_files/shuttles/emergency_lance.dmm
index 51c690540983..4304275d5861 100644
--- a/_maps/map_files/shuttles/emergency_lance.dmm
+++ b/_maps/map_files/shuttles/emergency_lance.dmm
@@ -472,9 +472,6 @@
 /obj/structure/window/reinforced{
 	dir = 1
 	},
-/obj/effect/mapping_helpers/airlock/windoor/access/all/command{
-	dir = 4
-	},
 /obj/machinery/door/window/reinforced/normal{
 	name = "Last Resort";
 	dir = 4
@@ -487,6 +484,9 @@
 	pixel_y = -6
 	},
 /obj/item/gun/energy/gun/mini,
+/obj/effect/mapping_helpers/airlock/windoor/access/all/command/general{
+	dir = 4
+	},
 /turf/simulated/floor/plasteel/dark,
 /area/shuttle/escape)
 "vk" = (
diff --git a/_maps/map_files/stations/emeraldstation.dmm b/_maps/map_files/stations/emeraldstation.dmm
index 06651b3812b6..158a2b4046ff 100644
--- a/_maps/map_files/stations/emeraldstation.dmm
+++ b/_maps/map_files/stations/emeraldstation.dmm
@@ -22718,8 +22718,8 @@
 	},
 /obj/machinery/atmospherics/pipe/simple/hidden/supply,
 /obj/machinery/atmospherics/pipe/simple/hidden/scrubbers,
-/obj/effect/mapping_helpers/airlock/access/any/command,
 /obj/machinery/door/firedoor,
+/obj/effect/mapping_helpers/airlock/access/any/command/general,
 /turf/simulated/floor/plasteel{
 	icon_state = "dark"
 	},
@@ -55406,7 +55406,7 @@
 	d2 = 2;
 	icon_state = "1-2"
 	},
-/obj/effect/mapping_helpers/airlock/windoor/access/all/command,
+/obj/effect/mapping_helpers/airlock/windoor/access/all/command/general,
 /turf/simulated/floor/plasteel,
 /area/station/command/bridge)
 "klt" = (
diff --git a/tools/maplint/lints/generic_access_helpers.yml b/tools/maplint/lints/generic_access_helpers.yml
new file mode 100644
index 000000000000..82d3f0a75fa7
--- /dev/null
+++ b/tools/maplint/lints/generic_access_helpers.yml
@@ -0,0 +1,71 @@
+help: 'These access helpers are only organizational and do not provide any access. Use one of the appropriate subtypes.'
+=/obj/effect/mapping_helpers/airlock/windoor/access/all:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/command:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/engineering:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/medical:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/science:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/security:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/service:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/all/supply:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/command:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/engineering:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/medical:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/science:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/security:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/service:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/windoor/access/any/supply:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/centcomm:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/command:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/engineering:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/medical:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/ruins:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/science:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/security:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/service:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/shuttles:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/all/supply:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/command:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/engineering:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/medical:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/science:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/security:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/service:
+  banned: true
+=/obj/effect/mapping_helpers/airlock/access/any/supply:
+  banned: true