From 9f4858ca13c29afa76a302f5e486b9d0976f260f Mon Sep 17 00:00:00 2001
From: Youssef Echaouqui <mr.echaouqui@gmail.com>
Date: Thu, 24 Oct 2024 16:30:49 +0100
Subject: [PATCH] Test Laravel Validation

---
 app/Http/Controllers/PostController.php    |  3 +++
 app/Http/Controllers/ProfileController.php |  1 +
 app/Http/Controllers/UserController.php    |  2 +-
 app/Http/Requests/StoreBuildingRequest.php |  7 ++++++
 app/Http/Requests/StoreItemRequest.php     | 29 ++++++++++++++++++++++
 app/Rules/StoreItemRequest.php             | 19 ++++++++++++++
 app/Rules/Uppercase.php                    | 21 ++++++++++++++++
 resources/views/products/create.blade.php  |  3 +++
 resources/views/projects/create.blade.php  |  9 +++++++
 resources/views/teams/create.blade.php     |  2 +-
 10 files changed, 94 insertions(+), 2 deletions(-)
 create mode 100644 app/Http/Requests/StoreItemRequest.php
 create mode 100644 app/Rules/StoreItemRequest.php
 create mode 100644 app/Rules/Uppercase.php

diff --git a/app/Http/Controllers/PostController.php b/app/Http/Controllers/PostController.php
index cd0808b7..81747ff5 100644
--- a/app/Http/Controllers/PostController.php
+++ b/app/Http/Controllers/PostController.php
@@ -12,6 +12,9 @@ public function store(Request $request)
         $request->validate(
             // ... TASK: write validation here so that "title" field
             //           would be required and unique in the "posts" DB table
+            [
+                'title' => 'required|unique:posts'
+            ]
         );
 
         // Saving the post
diff --git a/app/Http/Controllers/ProfileController.php b/app/Http/Controllers/ProfileController.php
index bb6bab39..e579c8dc 100644
--- a/app/Http/Controllers/ProfileController.php
+++ b/app/Http/Controllers/ProfileController.php
@@ -13,6 +13,7 @@ public function update(Request $request)
             // <input name="profile[name]" ... />
             // <input name="profile[email]" ... />
             // Write validation rules, so both name and email are required
+            'profile.name' => 'required',
         ]);
 
         auth()->user()->update($request->profile ?? []);
diff --git a/app/Http/Controllers/UserController.php b/app/Http/Controllers/UserController.php
index 404d7471..0523664a 100644
--- a/app/Http/Controllers/UserController.php
+++ b/app/Http/Controllers/UserController.php
@@ -11,7 +11,7 @@ public function update(User $user, UpdateUserRequest $request)
     {
         // TASK: change this line to not allow is_admin field to be updated
         // Update only the fields that are validated in UpdateUserRequest
-        $user->update($request->all());
+        $user->update($request->except('is_admin'));
 
         return 'Success';
     }
diff --git a/app/Http/Requests/StoreBuildingRequest.php b/app/Http/Requests/StoreBuildingRequest.php
index fbd8c064..a917fbff 100644
--- a/app/Http/Requests/StoreBuildingRequest.php
+++ b/app/Http/Requests/StoreBuildingRequest.php
@@ -30,4 +30,11 @@ public function rules()
             'name' => 'required'
         ];
     }
+
+    public function messages()
+    {
+        return [
+            'name.required' => 'Please enter the name'
+        ];
+    }
 }
diff --git a/app/Http/Requests/StoreItemRequest.php b/app/Http/Requests/StoreItemRequest.php
new file mode 100644
index 00000000..dd49c6f4
--- /dev/null
+++ b/app/Http/Requests/StoreItemRequest.php
@@ -0,0 +1,29 @@
+<?php
+
+namespace App\Http\Requests;
+
+use Illuminate\Foundation\Http\FormRequest;
+
+class StoreItemRequest extends FormRequest
+{
+    /**
+     * Determine if the user is authorized to make this request.
+     */
+    public function authorize(): bool
+    {
+        return true;
+    }
+
+    /**
+     * Get the validation rules that apply to the request.
+     *
+     * @return array<string, \Illuminate\Contracts\Validation\Rule|array|string>
+     */
+    public function rules(): array
+    {
+        return [
+            'name' => ['required'],
+            'description' => ['required'],
+        ];
+    }
+}
diff --git a/app/Rules/StoreItemRequest.php b/app/Rules/StoreItemRequest.php
new file mode 100644
index 00000000..3fb6193b
--- /dev/null
+++ b/app/Rules/StoreItemRequest.php
@@ -0,0 +1,19 @@
+<?php
+
+namespace App\Rules;
+
+use Closure;
+use Illuminate\Contracts\Validation\ValidationRule;
+
+class StoreItemRequest implements ValidationRule
+{
+    /**
+     * Run the validation rule.
+     *
+     * @param  \Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
+     */
+    public function validate(string $attribute, mixed $value, Closure $fail): void
+    {
+        //
+    }
+}
diff --git a/app/Rules/Uppercase.php b/app/Rules/Uppercase.php
new file mode 100644
index 00000000..14f7b0df
--- /dev/null
+++ b/app/Rules/Uppercase.php
@@ -0,0 +1,21 @@
+<?php
+
+namespace App\Rules;
+
+use Closure;
+use Illuminate\Contracts\Validation\ValidationRule;
+
+class Uppercase implements ValidationRule
+{
+    /**
+     * Run the validation rule.
+     *
+     * @param  \Closure(string): \Illuminate\Translation\PotentiallyTranslatedString  $fail
+     */
+    public function validate(string $attribute, mixed $value, Closure $fail): void
+    {
+        if (strtoupper($value[0]) !== $value[0]) {
+            $fail('The :attribute does not start with an uppercased letter');
+        }
+    }
+}
diff --git a/resources/views/products/create.blade.php b/resources/views/products/create.blade.php
index 611b7ef6..67534f9c 100644
--- a/resources/views/products/create.blade.php
+++ b/resources/views/products/create.blade.php
@@ -9,6 +9,9 @@
     {{-- @directive --}}
     {{-- {{ $message }} --}}
     {{-- @endDirective --}}
+    @error('name')
+        <div>{{ $message }}</div>
+    @enderror
     <br /><br />
     <button type="submit">Save</button>
 </form>
diff --git a/resources/views/projects/create.blade.php b/resources/views/projects/create.blade.php
index dc19b63b..7cd21598 100644
--- a/resources/views/projects/create.blade.php
+++ b/resources/views/projects/create.blade.php
@@ -6,6 +6,15 @@
 
 <form method="POST" action="{{ route('projects.store') }}">
     @csrf
+    @if($errors->any())
+        <div>
+            <ul>
+                @foreach($errors->all() as $error)
+                    <li>{{ $error }}</li>
+                @endforeach
+            </ul>
+        </div>
+    @endif
     Title:
     <br />
     <input type="text" name="title" />
diff --git a/resources/views/teams/create.blade.php b/resources/views/teams/create.blade.php
index 2d003c05..37ae1412 100644
--- a/resources/views/teams/create.blade.php
+++ b/resources/views/teams/create.blade.php
@@ -3,7 +3,7 @@
     Name:
     <br />
     {{-- TASK: change this field so it would contain old value after validation error --}}
-    <input type="text" name="name" />
+    <input type="text" name="name" value="{{ old('name') }}"/>
     <br /><br />
     <button type="submit">Save</button>
 </form>