Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram sort order #56

Open
patrickjohncyh opened this issue Jan 18, 2018 · 1 comment
Open

Histogram sort order #56

patrickjohncyh opened this issue Jan 18, 2018 · 1 comment

Comments

@patrickjohncyh
Copy link

patrickjohncyh commented Jan 18, 2018

The spec specifies that the primary sort order as :

"primary sort order: the number of times it occurs, from least to most."

However, the reference for test 6 orders the histogram from most to least.

@m8pple
Copy link
Contributor

m8pple commented Jan 19, 2018

Yes, you're right - the reference output relies on the sort order defined in histogram_main.cpp,
which is actually the other way round (the same as for test 6).

I'll stick with the version in the code and modify the text, as it is intended that people don't
need to deal with that part.

I usually try to modify lab exercises each year at a surface level to discourage temporal migration
of solutions/code - I think this is a consequence of that.

Thanks for spotting that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants