[로또 게임] 양재승 과제 제출합니다. #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix to push list winningNumber
sunwootest
requested changes
Jul 8, 2023
src/main/java/lotto/Calculator.java
Outdated
Comment on lines
52
to
60
| public void printResult(){ | ||
| System.out.println("당첨 통계"); | ||
| System.out.println("---"); | ||
| System.out.println("3개 일치 (5,000원) - " + countThree + "개"); | ||
| System.out.println("4개 일치 (50,000원) - " + countFour + "개"); | ||
| System.out.println("5개 일치 (1,500,000원) - " + countFive + "개"); | ||
| System.out.println("5개 일치, 보너스 볼 일치 (30,000,000원) - " + countFiveAndBonus + "개"); | ||
| System.out.println("6개 일치 (2,000,000,000원) - " + countSix + "개"); | ||
| } |
There was a problem hiding this comment.
한번의 System 메소드 호출로 출력하도록 개선해보세요. 개행문자를 적절히 사용하면 가독성도 개선할 수 있겠네요.
Comment on lines
6
to
23
| public class ExceptionController { | ||
|
|
||
| public static void noIntegerValueException(String Numbers){ | ||
| for(int i=0; i<Numbers.length(); i++){ | ||
| int isIntger = Numbers.charAt(i) - '0'; | ||
| if(isIntger<0 || isIntger>9){ | ||
| System.out.println(NOT_INTAGER_ERROR_MESSAGE); | ||
| throw new IllegalArgumentException(); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public static void noValidAmountException(String amount){ | ||
| if(Integer.parseInt(amount)%1000 != 0){ | ||
| System.out.println(NOT_THOUSAND_ERROR_MESSAGE); | ||
| throw new IllegalArgumentException(); | ||
| } | ||
| } |
There was a problem hiding this comment.
예외를 던지기만 하지 처리를 하진 않습니다. 첫번째 과제에선 예외를 던지기만 해도 요구사항을 충족했는데 이번 과제는 더 개선해야 합니다 :)
에러메시지를 어떻게 출력할 수 있는지 알아보세요.
src/main/java/lotto/Calculator.java
Outdated
Comment on lines
26
to
44
| switch (correctCount) { | ||
| case 3: | ||
| countThree++; | ||
| totalIncome += 5000; | ||
| break; | ||
| case 4: | ||
| countFour++; | ||
| totalIncome += 50000; | ||
| break; | ||
| case 5: | ||
| countFive++; | ||
| totalIncome += 1500000; | ||
| break; | ||
| case 6: | ||
| countSix++; | ||
| totalIncome += 2000000000; | ||
| break; | ||
|
|
||
| } |
There was a problem hiding this comment.
클린코드의 영역인데 switch case문은 지양하는 편이 좋습니다.
src/main/java/lotto/LottoGame.java
Outdated
Comment on lines
10
to
18
| LottoGame(){ | ||
| System.out.println(Message.INPUT_PURCHASE_AMOUNT.getMessage()); | ||
| String amount = Console.readLine(); | ||
|
|
||
| ExceptionController.noIntegerValueException(amount); | ||
| ExceptionController.noValidAmountException(amount); | ||
|
|
||
| coin = Integer.parseInt(amount)/1000; | ||
| } |
There was a problem hiding this comment.
메소드로 분리해봅시다. 초기화 한다는 측면에서 생성자의 역할을 하는 것 처럼 보이지만 입출력, 예외처리 등 너무 많은 관심사들이 섞여있습니다.
src/main/java/lotto/LottoList.java
Outdated
| import java.util.List; | ||
|
|
||
| public class LottoList { | ||
| Lotto[] lottos; |
There was a problem hiding this comment.
숫자의 개수가 늘어나도 동작하도록 리팩토링 해보세요.
src/main/java/lotto/LottoGame.java
Outdated
Comment on lines
10
to
27
| LottoGame(){ | ||
| System.out.println(Message.INPUT_PURCHASE_AMOUNT.getMessage()); | ||
| String amount = Console.readLine(); | ||
|
|
||
| ExceptionController.noIntegerValueException(amount); | ||
| ExceptionController.noValidAmountException(amount); | ||
|
|
||
| coin = Integer.parseInt(amount)/1000; | ||
| } | ||
|
|
||
| public void run(){ | ||
| lottoList = new LottoList(coin); | ||
| winningNumbers = new WinningNumbers(); | ||
|
|
||
| Calculator calculator = new Calculator(lottoList, winningNumbers); | ||
| calculator.printResult(); | ||
| calculator.printIncomeRate(coin); | ||
| } |
There was a problem hiding this comment.
생성자를 위와 같이 구현했다면 필드에 있는 lottoList와 winningNumbers를 생성자에서 초기화하는 것이 더 자연스럽지 않을까요?
src/main/java/lotto/LottoGame.java
Outdated
Comment on lines
5
to
8
| public class LottoGame { | ||
| LottoList lottoList; | ||
| WinningNumbers winningNumbers; | ||
| int coin; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
로또 클래스를 클래스 배열로 나누었고
계산기능 함수들을 묶어 클래스로 만들었습니다.
한가지 궁금한 점은 예외처리 결과는 잘 나오는데 테스트 코드가 pass가 안되는데, 혹시 단지 기능 구현 문제인지 테스트 코드 형식에 틀리기 때문인지가 궁금합니다
남은시간 리팩토링에 몰두하겠습니다! 감사합니다!