Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sawmill blade spining in the wrong direction (MC-190774) #2

Open
wants to merge 2 commits into
base: 1.18
Choose a base branch
from

Conversation

EcoBuilder13
Copy link

This fixes MC-190774 for the sawmill. Prior to this commit the blade spins the opposite direction on the other side of the sawmill. This pull request fixes that.

@EcoBuilder13
Copy link
Author

Also a small note is that the sawmill spins in the opposite direction as the stonecutter. This may be intentional or not but I have left it as is for you to decide.

@LucilleTea
Copy link

LucilleTea commented Apr 8, 2021

This bug is marked as fixed in 21w13a, and this mod is now updated to 21w14a, so the PR no longer applies. Though I'm not sure such a fix makes sense for Aurora's Decorations anyway?

@EcoBuilder13
Copy link
Author

@LucilleTea This only fixes the Sawmill added by AurorasDecorations. The original bug is caused by the saw texture being improperly flipped when it is uv mapped in the model. I pulled the new model out of the 21w13a jar and I can confirm that what they did to fix it was change the x1 and x2 values because it was forgotten to be flipped on the opposite side. If you look at the difference in that commit you will see I applied the fix to the sawmill's model. The bug is present in the model since it just uv maps the saw texture onto the location specified. So when the model was made the saw blade was not flipped just like what happened in the vanilla game with the stonecutter. So I have simply just fixed that.

@LucilleTea
Copy link

Oh I am a dummy, good context :p

@LambdAurora
Copy link
Owner

The author of the sawmill model considers that the sawmill has twin blades which rotates in different directions.

@EcoBuilder13
Copy link
Author

I've changed the direction of the saw in the model to match the saw on the stonecutter. This can be reverted if you want it to spin the opposite direction or if the blades spinning in opposite directions on different sides of the sawmill the pull request can be closed.

@EcoBuilder13 EcoBuilder13 changed the base branch from 1.17 to 1.18 January 8, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants