Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings page #71

Open
diegoalvis opened this issue Oct 7, 2020 · 29 comments
Open

Settings page #71

diegoalvis opened this issue Oct 7, 2020 · 29 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2020

Comments

@diegoalvis
Copy link
Member

Add a setting page with the following options. Please note you just have to add the options not the actual functionality for each one.

  1. Dark mode (toggle/switch)
  2. Notifications (toggle/switch)
  3. Contributors
  4. About OpenSource Contribution
@diegoalvis diegoalvis added enhancement New feature or request hacktoberfest Hacktoberfest 2020 labels Oct 7, 2020
@diegoalvis diegoalvis changed the title Setting page Settings page Oct 7, 2020
@diegoalvis diegoalvis added the good first issue Good for newcomers label Oct 7, 2020
@tushar-suthar
Copy link

tushar-suthar commented Oct 7, 2020

i would like to make PR in this please assign me.

@diegoalvis
Copy link
Member Author

Ok @code-netizen all yours!

@tushar-suthar
Copy link

tushar-suthar commented Oct 8, 2020

@diegoalvis I am pretty completed up with setting page code but not able to run app as production.env is not in assets.Please tell a way for production.env to start the app on android studio.

@diegoalvis
Copy link
Member Author

@code-netizen please create a development.env file. You can find the instructions in README.md about how to get back4app credentials and how to set up then dot.env file

@tushar-suthar
Copy link

I have already created development.env but there is one more file needed in assets production.env what to do with that

@diegoalvis
Copy link
Member Author

diegoalvis commented Oct 9, 2020

@code-netizen you can comment/remove that line and modify the EnvironmentConfiguration
To use the same file for both variants

class EnvironmentConfiguration {
  static Future run() async {
    const bool isProduction = bool.fromEnvironment('dart.vm.product');
    final envFileName = isProduction ? "production.env" : "development.env";
    ...

replace this
final envFileName = isProduction ? "production.env" : "development.env";

for this
final envFileName = "development.env";

I've updated the repo with that change if you prefer you can update yours as well.

@tushar-suthar
Copy link

@diegoalvis i have made changes as you said but now in some file due to production.env there is error as in android/app/src/main/androidmanifest.xml there is some problem. Due to app not starting i an not able to see appearance and working of app.

@tushar-suthar
Copy link

tushar-suthar commented Oct 9, 2020

And i have made setting page class so if you want i will make PR of that code so that you can apply in your code base as import.

@tushar-suthar
Copy link

@diegoalvis see into this so that i can run the app and add setting page in it.

@diegoalvis
Copy link
Member Author

@code-netizen apologize you have gone through this. Missing google maps api key was added to develop branch. Let me know if you can run the app after this

@tushar-suthar
Copy link

tushar-suthar commented Oct 9, 2020

@diegoalvis I am having some problem with androidmanifest in android/app/src/main of which I have send you a screenshot above in which .mainactivity and other are having error(red coloured).

@diegoalvis
Copy link
Member Author

@code-netizen error is related to missing google maps key, take a look at the build.gradle app level.
The reason is that the manifest is expecting a value for that, you can added whatever string since we're not using maps currently

@tushar-suthar
Copy link

tushar-suthar commented Oct 9, 2020

@diegoalvis facing above problem
i think target sdk version is not latest
and its saying error in line 17 GradleException gradle.build

@tushar-suthar
Copy link

@diegoalvis still not able to run app even I have made some changes to resolve error but it didn't solved the issue.

@diegoalvis
Copy link
Member Author

@code-netizen will update the SDK but still doesn’t seem like that is the error
@llanox could you clone the project and try to run it in your end and confirm if you got these issues?

@tushar-suthar
Copy link

tushar-suthar commented Oct 11, 2020

@diegoalvis @llanox the app has been installed but showing only white screen

@tushar-suthar
Copy link

Screenshot (234)

@tushar-suthar
Copy link

see console message

@diegoalvis
Copy link
Member Author

@code-netizen issue seems to be related to null safety call at my_address_page.dart class line 83
child: cityList?.isNotEmpty != true

I've added a null check before it would be fix the problem (branch develop), let me know if it works since I cannot reproduce the issue.
I also suggest to clean up the project and run flutter upgrade command due null safety call was changed in the latest version of flutter sdk

@tushar-suthar
Copy link

No again the app is installed with some warnings in log and showing only blank screen. I have made all above changes stated by you.

@diegoalvis
Copy link
Member Author

@code-netizen can you share your .env file?

@tushar-suthar
Copy link

Once the keys have been added rename this file for development.env

API Settings (LA_CORO PUBLIC DB) https://www.back4app.com/database/admin7/lacoro

BASE_URL=https://parseapi.back4app.com
PARSE_APPLICATION_ID=CV76bmzooUdKrAPaGxVSxJvVH5SXaWOFYli5MEvQ
PARSE_CLIENT_ID=3xgekfc1ClhcvTfa3YN8f4BYwcoQwEOZUfnehtOa
PARSE_MASTER_KEY=Z2gBx8y0nPYKAHKkwFNQCv9o4d72zFXCHBKbzftd

@diegoalvis
Copy link
Member Author

diegoalvis commented Oct 18, 2020

@code-netizen develop branch running on Mac OS 10.15.4 (Catalina)
with the following development.env file


# API Settings (LA_CORO PUBLIC DB) https://www.back4app.com/database/admin7/lacoro
BASE_URL=https://parseapi.back4app.com
PARSE_APPLICATION_ID=CV76bmzooUdKrAPaGxVSxJvVH5SXaWOFYli5MEvQ
PARSE_CLIENT_ID=3xgekfc1ClhcvTfa3YN8f4BYwcoQwEOZUfnehtOa
PARSE_MASTER_KEY=Z2gBx8y0nPYKAHKkwFNQCv9o4d72zFXCHBKbzftd

#PUBNUB KEYS (not mandatory)
PUBNUB_SUBSCRIBE_KEY=<pubnub_subscribe_key>
PUBNUB_PUBLISH_KEY=<pubnub_publish_key>

It might be a OS related issue. What OS are you using?

@llanox did you have the chance to run the app on Windows?

@tushar-suthar
Copy link

@diegoalvis i am using windows

@diegoalvis
Copy link
Member Author

I opened an issue for this #75

@llanox
Copy link
Member

llanox commented Oct 22, 2020

Hey guys!!
@diegoalvis @code-netizen
Finally, I managed to get a laptop with windows. I didn't see any problem building the project and deploying it with your credentials. Please, double-check you are using one of the following cities with data: "Villavicencio" or "Ibague". Those are the only cities with stores in the demo database. Let me know if you can see the list of stores when you change the city.

@diegoalvis We need to add empty states to our roadmap

Thanks,

demo

@shathurshan
Copy link

I am interested to make pull request please add me.

@diegoalvis
Copy link
Member Author

Hey @shathurshan I've assigned the issue to you as we didn’t get any update from @code-netizen

@rahul-badgujar
Copy link

hii - please assign this issue to me - I am interested to contribute on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Hacktoberfest 2020
Projects
None yet
Development

No branches or pull requests

5 participants