Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move calculated_point_estimates logic into CatEstimator base class #41

Closed
drewoldag opened this issue Aug 14, 2023 · 1 comment · Fixed by #42 or #48
Closed

Move calculated_point_estimates logic into CatEstimator base class #41

drewoldag opened this issue Aug 14, 2023 · 1 comment · Fixed by #42 or #48
Assignees

Comments

@drewoldag
Copy link
Collaborator

I started implementing logic to obey self.config.calculated_point_estimates in the various subclasses of CatEstimator assuming that the work to actually calculate the point estimates would be slightly different for each estimator. In fact it is largely the same, so the logic can be moved into CatEstimator base class.

@drewoldag drewoldag self-assigned this Aug 14, 2023
drewoldag added a commit that referenced this issue Sep 12, 2023
…imate

Adding logic to `CatEstimator` to obey `calculated_point_estimates`.
@drewoldag
Copy link
Collaborator Author

Going to do a little more work on this issue:

  • Abstract the point estimate code into a mixin class.
  • Make a call to PointEstimateMixin.calculate_point_estimate in the _do_chunk_output.

@drewoldag drewoldag reopened this Sep 12, 2023
@drewoldag drewoldag linked a pull request Sep 12, 2023 that will close this issue
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant