Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base classes for "recalibration" techniques #27

Open
aimalz opened this issue Jul 27, 2023 · 2 comments
Open

Base classes for "recalibration" techniques #27

aimalz opened this issue Jul 27, 2023 · 2 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@aimalz
Copy link
Collaborator

aimalz commented Jul 27, 2023

There's been a lot of discussion of "recalibration" methods for n(z) and p(z)s, and they would best fit into the current framework as a summarizer accepting the n(z) output of another summarizer plus other information as input and outputting n(z) and an estimator accepting the p(z) output of another estimator plus other information as input and outputting p(z)s, respectively. Our Estimator and Summarizer stage superclasses are defined by what kinds of inputs they need, so this issue is for making those base classes and at least one "dummy" subclass for each so there can be placeholder stages for these procedures in pipelines currently under development.

@aimalz aimalz added enhancement New feature or request good first issue Good for newcomers labels Jul 27, 2023
@sschmidt23 sschmidt23 removed good first issue Good for newcomers enhancement New feature or request labels Jul 27, 2023
@sschmidt23
Copy link
Collaborator

I think we should have the discussion on the expected form that this will take before we think about the class structure. This could be something that better lives outside of RAIL, or it might all fit within RAIL, but I don't think that we'll know for sure until we have a more concrete pipeline diagram written down (which should be done with outside groups using tomographic N(z) involved in the discussion as well).

@aimalz aimalz added enhancement New feature or request question Further information is requested labels Jul 27, 2023
@aimalz
Copy link
Collaborator Author

aimalz commented Jul 27, 2023

Fair point, I added the "question" label so we know to discuss it broadly before taking any action on implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants