Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change installation guide for delight #164

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hangqianjun
Copy link
Contributor

Problem & Solution Description (including issue #)

Addressing #163:

  • Delight needs to be installed first before installing the rail wrapper
  • On Mac, one needs to configure the c compilers correctly.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b14421) to head (1d6c94b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #164   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hangqianjun
Copy link
Contributor Author

Hi @sschmidt23 ! Is this mac installation guide for delight: https://github.com/LSSTDESC/Delight/blob/master/Mac_installation.md
what you mentioned yesterday at the tag up, and is it still working for Mac M2?

@sschmidt23
Copy link
Collaborator

Yes, that's the one, though we should check whether gcc-11 is still the latest version, or if gcc-12 or 13 or something exists now, given that it's been two years since we added this readme.

@hangqianjun
Copy link
Contributor Author

@sschmidt23 The latest version seems to be 14.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants