Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cosmos seds to demo nb #161 #162

Merged
merged 1 commit into from
Oct 2, 2024
Merged

add cosmos seds to demo nb #161 #162

merged 1 commit into from
Oct 2, 2024

Conversation

sschmidt23
Copy link
Collaborator

Update the BPZ demo notebook so that it includes a run with additional SEDs (see #166 in rail_base, which will need to be merged first before this updated notebook will successfully run). I added comparisons of CWWSB to the COSMOS SEDs and show that scatter is reduced at the expense of 3-4x the runtime.

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@sschmidt23 sschmidt23 linked an issue Oct 1, 2024 that may be closed by this pull request
3 tasks
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (b14fc48) to head (73518eb).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #162   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hangqianjun hangqianjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sschmidt23 sschmidt23 merged commit 9b14421 into main Oct 2, 2024
6 checks passed
@sschmidt23 sschmidt23 deleted the issue/161/bpznb branch October 2, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add COSMOS SED usage to BPZ demo notebook
2 participants