Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly deal with bright defocused objects #412

Open
cwwalter opened this issue Aug 29, 2023 · 3 comments
Open

Properly deal with bright defocused objects #412

cwwalter opened this issue Aug 29, 2023 · 3 comments
Labels
Milestone

Comments

@cwwalter
Copy link
Member

cwwalter commented Aug 29, 2023

In testing imSim 2.0 I saw we neglected to handle the case where very bright objects are being imaged on out-of-focus sensors. This includes both the wavefront sensors and intra and extra focal focal plane images. This is due to the switch over to FFT imaging for very bright objects which bypasses the ray-tracing.

The following image demonstrates the problem. Note the in-focus bright stars among the donuts:

image
@cwwalter cwwalter added the bug label Aug 29, 2023
@cwwalter cwwalter added this to the imSim 2.0 milestone Aug 29, 2023
@cwwalter
Copy link
Member Author

cwwalter commented Aug 29, 2023

So far discussions have noted:

  • The light is spread over many more pixels in a donut. So, the saturation and full well conditions will be different.
  • One approach might be to clip the flux and really do raytracing for bright objects on out of focus surfaces. Bright enough objects might then need to be scaled.
  • To do this we would probably need to use batoid to fire some test rays to determine if/where stars are out of focus.

@cwwalter
Copy link
Member Author

For reference these are the limits used by the AOS wavefront estimation pipelines for selecting stars:

https://github.com/lsst-ts/ts_wep/blob/develop/policy/task/magLimitStar.yaml

@sidneymau
Copy link

One thought would be to do a fractional fourier transform on these objects to draw them out of focus. This might take some work to implement, however (particularly computing the correct fraction for the transform as a function of sensor height)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants