Use libgap for Galois groups, fix some latex errors #6144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently https://beta.lmfdb.org/GaloisGroup/40T192781 times out, since Galois Groups are using the deprecated pexpect interface to gap, rather than the more modern libgap interface. Switching improves the load time (though perhaps there are more optimizations that could be done). We also fix a latex error in the conjugacy class knowl (previously, the columns of the knowl accessible by clicking on "The 1912 conjugacy class representatives for C_5^8.C_4^3.C_2^2" were not latexed).