Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyError introduced by #26 #36

Open
isehle opened this issue Mar 31, 2023 · 1 comment
Open

KeyError introduced by #26 #36

isehle opened this issue Mar 31, 2023 · 1 comment
Assignees
@isehle

Comments

@isehle
Copy link
Collaborator

isehle commented Mar 31, 2023

The updated configuration introduced by #26 in config.yaml refers to this as cfg["clusterStudies"]["pileUp"]. This appears to have been correctly changed everywhere else, but this one was missed—easy fix, I'll introduce a PR for it soon.

https://github.com/bfonta/bye_splits/blob/15dcbdb0955969550f301d90d06b5a741c4af0e1/bye_splits/plot/display_clusters/pages/eff_page.py#L27
@isehle isehle self-assigned this Mar 31, 2023
@bfonta
Copy link
Collaborator

bfonta commented May 1, 2023

I understand this will be fixed by your future PR. Please link a development branch to this PR, so that it is closed as soon as you implement the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@isehle isehle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

temp/rewrite_plotting isehle/bye_splits
2 participants
@bfonta @isehle