Remove deprecation warning. #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ially diabling the capability. Unfortunately, we do now have a replacement for it yet.
|
/style |
|
I would prefer to fix this in a more direct way: change the compiler flags so that we don't promote deprecation warnings to errors (but still promote other warnings to errors). I think this is possible. I don't want to remove the deprecation. |
btalamini
approved these changes
Jan 7, 2025
white238
approved these changes
Jan 7, 2025
|
OK, I think we can consider turn off this warning in the future, and can maybe start doing deprecations at that time? For now, its going in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its warnings to errors, so this is essentially disabling the capability. Unfortunately, we do now have a replacement for it yet, nor a design planned to replace it, as far as I'm aware. We could consider making it more consistent with the new BC interface, e.g. taking Components an using tensor, instead of mfem::Vector.