Fixes for builds with no raja or umpire #1307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebchin
commented
Jan 3, 2025
| blt_list_append(TO infrastructure_depends ELEMENTS tribol IF TRIBOL_FOUND) | ||
| blt_list_append(TO infrastructure_depends ELEMENTS caliper adiak::adiak IF SERAC_ENABLE_PROFILING) | ||
| blt_list_append(TO infrastructure_depends ELEMENTS blt::openmp IF SERAC_ENABLE_OPENMP) |
There was a problem hiding this comment.
I don't think this is needed, but the openmp dependency for mfem wasn't picked up through FindMFEM.cmake. Any ideas on how to fix this @white238 @chapman39 ? This is with clang 16.0.6 on Ubuntu 24.04
There was a problem hiding this comment.
what happens when you call blt_print_target_properties(TARGET mfem)? also can you check to see if mfem was built with +openmp in the concretizer tree?
|
/style |
ebchin
force-pushed
the
bugfix/chin23/no-raja-umpire
branch
from
35a1037 to
d5747e1
Compare
white238
approved these changes
Jan 3, 2025
tupek2
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in place of the (now closed) #1270.
Instead of
#ifdefs on the function declaration, I added amemory.hppwhich holds different hostaxom::MemorySpaces depending on if serac is built with Umpire or not. This variable is then used in template parameters.