Move git sha header to better location

[chapman39]

I've been testing a serac-only lido build and noticed something weird about the git sha header... in serac, git_sha.hpp is being configured into ${PROJECT_BINARY_DIR}/include/serac/infrastructure, but in smith (which is what lido has been testing against) configures it in an entirely different location: ${CMAKE_BINARY_DIR}/include/serac/infrastructure.

Smith shouldn't need to configure this file in the first place, so it has been removed in the associated Smith MR.

I've updated Serac and Smith so that this header is being configured to a consistent location: ${CMAKE_BINARY_DIR}/include/serac

[chapman39]

I'm not sure if this conflicts with what you were trying to do in this PR @white238 #637 , but we can talk about it after break.

[chapman39]

Please do not update this branch with develop until it's finalized, since Id like to get this change into lido without doing a tpl rebuild.

[white238]

We should be using PROJECT_BINARY_DIR instead of CMAKE_BINARY_DIR in every place we can because it guarantees there will never be a conflict with downstream projects.

This is should also be fixed:

serac/src/serac/infrastructure/CMakeLists.txt

Line 61 in a44317b

$<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/include>

Were there conflicts you seeing or was it inconsistency?

[chapman39]

Were there conflicts you seeing or was it inconsistency?

This is the error I was seeing, since the LiDO build was relying on Smith to configure the git sha header again in a different location.

/usr/workspace/meemee/lido-2.0/repo/smith/serac/src/serac/infrastructure/about.cpp:47:10: fatal error: 'serac/infrastructure/git_sha.hpp' file not found
#include "serac/infrastructure/git_sha.hpp"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

[chapman39]

This is should also be fixed:

I think that one fix is all that was needed after all

[chapman39]

see #1304