Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard missed test and document how to style #1210

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

white238
Copy link
Member

@white238 white238 added CI Continuous Integration build Build system labels Aug 12, 2024
@white238
Copy link
Member Author

white238 commented Aug 12, 2024

The Spack team also adds a comment to the GitHub Pull Request Template to tell you all the automated things their SpackBot can do. We only have /style but we could put a comment there to remind people. @samuelpmishLLNL do you think that would be helpful?

@samuelpmishLLNL
Copy link
Contributor

We only have /style but we could put a comment there to remind people. @samuelpmishLLNL do you think that would be helpful?

I think the note in the readthedocs suffices

Comment on lines +49 to +51
The second method is to make a comment of ``/style`` on your open GitHub pull request. This will trigger
a GitHub Action that will automatically style your code and commit it to your branch. You will need to
`git pull` after it is finished to continue to work on that branch.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who is allowed to make use of this /style command?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely anyone who has write access to our repo can trigger it. I would need to try what happens if someone outside our organization does it. They certainly cannot change the behavior or the GitHub Action.

@white238 white238 enabled auto-merge August 12, 2024 21:47
@white238 white238 merged commit 4ccc602 into develop Aug 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

save clang-format git patch as artifact on failure
3 participants