-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard missed test and document how to style #1210
Conversation
The Spack team also adds a comment to the GitHub Pull Request Template to tell you all the automated things their SpackBot can do. We only have |
I think the note in the readthedocs suffices |
The second method is to make a comment of ``/style`` on your open GitHub pull request. This will trigger | ||
a GitHub Action that will automatically style your code and commit it to your branch. You will need to | ||
`git pull` after it is finished to continue to work on that branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is allowed to make use of this /style
command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely anyone who has write access to our repo can trigger it. I would need to try what happens if someone outside our organization does it. They certainly cannot change the behavior or the GitHub Action.
https://serac.readthedocs.io/en/task-white238-guard_missed_test/sphinx/dev_guide/style_guide.html#how-to-style-your-code
Fixes #1208