Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construction of dump dirpath not appending '/' #3

Open
aowenson opened this issue Sep 5, 2017 · 3 comments
Open

Construction of dump dirpath not appending '/' #3

aowenson opened this issue Sep 5, 2017 · 3 comments

Comments

@aowenson
Copy link
Contributor

aowenson commented Sep 5, 2017

The check for whether PDUMP_DUMP_DIR ends with a '/' is faulty. The fix is to replace line 103:

if (!dump_dir_str[back] == '/') {

... with this:

if (dump_dir_str[back] != '/') {

... in perf_dump.C.

@tgamblin
Copy link
Member

tgamblin commented Sep 5, 2017

Care to submit a PR?

@aowenson
Copy link
Contributor Author

aowenson commented Sep 5, 2017

I assume you mean push a branch, and PR that? I did try to push but I was denied permission.

@tgamblin
Copy link
Member

tgamblin commented Sep 5, 2017

@aowenson: if you fork the repository, then push the branch in your own fork, you can submit a PR to the main perf-dump repo here. You don't need write access to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants