Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FluxScriptAdapter] Resources specified as a parameter are strings and break int comparisons #372

Open
FrankD412 opened this issue Aug 4, 2021 · 0 comments
Labels
bug Description of reproducible unexpected behavior. Confirmed Confirmed reproduction of a posted bug.

Comments

@FrankD412
Copy link
Member

When testing a specification with Flux, I ran into the case where a parameterized resource field was carried through as a string. The adapter should probably try and cast the resources to their appropriate type instead of assuming the data type will be right.

2021-08-04 16:02:53,330 - maestrowf.conductor:main:387 - ERROR - ("'>' not supported between instances of 'str' and 'int'",)
Traceback (most recent call last):
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/conductor.py", line 382, in main
    completion_status = conductor.monitor_study()
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/conductor.py", line 352, in monitor_study
    completion_status = dag.execute_ready_steps()
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/datastructures/core/executiongraph.py", line 920, in execute_ready_steps
    self._execute_record(_record, adapter)
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/datastructures/core/executiongraph.py", line 589, in _execute_record
    retcode = record.execute(adapter)
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/datastructures/core/executiongraph.py", line 112, in execute
    retcode, jobid = self._execute(adapter, self.script)
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/datastructures/core/executiongraph.py", line 142, in _execute
    self.step, script, self.workspace.value)
  File "/usr/WS2/fdinatal/pyenv/blueos_3_ppc64le_ib_p9/versions/3.6.9/envs/maestrowf/lib/python3.6/site-packages/maestrowf/interfaces/script/fluxscriptadapter.py", line 208, in submit
    if processors > 0 and processors > ncores:
TypeError: '>' not supported between instances of 'str' and 'int'
2021-08-04 16:02:53,398 - maestrowf.conductor:main:391 - INFO - Study exiting, cleaning up...
@FrankD412 FrankD412 added bug Description of reproducible unexpected behavior. Confirmed Confirmed reproduction of a posted bug. labels Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Description of reproducible unexpected behavior. Confirmed Confirmed reproduction of a posted bug.
Projects
None yet
Development

No branches or pull requests

1 participant