Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux: gpus key semantics should be total number of gpus #360

Open
SteVwonder opened this issue May 25, 2021 · 1 comment
Open

flux: gpus key semantics should be total number of gpus #360

SteVwonder opened this issue May 25, 2021 · 1 comment
Assignees
Labels
Adapters Items that are directly related to Maestro's adapter structure. enhancement Specification

Comments

@SteVwonder
Copy link
Member

In the 0.26.0 adaptor, parts of it assume that gpus means total number of gpus and other parts assume it means gpus_per_task. The adaptor should be modified to assume it means total number of gpus for consistency with the slurm adaptor

@FrankD412 FrankD412 added Adapters Items that are directly related to Maestro's adapter structure. enhancement Specification labels May 26, 2021
@FrankD412
Copy link
Member

Just a note for this issue as it was related.

Talking to @Jmast, he mentioned that he prefers to have the keys be in terms of cores per task and gpus per task, which is contra what you and I had discussed related to running math in the background where a user can't see it. I think favoring a gpus per task key would put this more in line with cpus per task and make things consistent -- meaning we would need to perform that math in the SLURM case.

@FrankD412 FrankD412 self-assigned this May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adapters Items that are directly related to Maestro's adapter structure. enhancement Specification
Projects
None yet
Development

No branches or pull requests

2 participants